From a0c57162b2026e37220e31a39d821c2a2e31cc51 Mon Sep 17 00:00:00 2001
From: Guillaume Hormiere <guillaume.hormiere@delair.aero>
Date: Wed, 22 Jul 2020 22:26:19 +0200
Subject: Use immutable vector instead of mutable one and change the message
 kind to Error

Apply code review
---
 src/app/impl_self.rs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

(limited to 'src')

diff --git a/src/app/impl_self.rs b/src/app/impl_self.rs
index 38162ee..8a84cb2 100644
--- a/src/app/impl_self.rs
+++ b/src/app/impl_self.rs
@@ -34,10 +34,7 @@ impl App {
     }
 
     pub fn list_habit(&self) -> Vec<String> {
-        let mut habits_names: Vec<String> = vec![];
-        for h in self.habits.iter() {
-            habits_names.push(h.name())
-        }
+        let habits_names = self.habits.iter().map(|x| x.name()).collect::<Vec<_>>();
         return habits_names;
     }
 
@@ -49,6 +46,7 @@ impl App {
             .count()
             > 0
         {
+            self.message.set_kind(MessageKind::Error);
             self.message
                 .set_message(format!("Habit `{}` allready exist", h.name()))
         } else {
-- 
cgit v1.2.3