aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_hir_def/src/nameres/collector.rs
diff options
context:
space:
mode:
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>2020-04-20 15:38:16 +0100
committerGitHub <[email protected]>2020-04-20 15:38:16 +0100
commit2e0b7b0159ed922693db48f3f94ed95b1827494a (patch)
treeede61469d8f4e180f0cfa7cbe00d889737d45551 /crates/ra_hir_def/src/nameres/collector.rs
parent90f837829d4f2c1054751de2de695ba1c0b8ae5c (diff)
parent8a04372fec5f26a0650395a1e420fea062b3a7ab (diff)
Merge #4057
4057: Fix panic in split_imports assist r=matklad a=matklad The fix is admittedly quit literally just papering over. Long-term, I see two more principled approaches: * we switch to a fully tree-based impl, without parse . to_string step; with this approach, there shouldn't be any panics. The results might be nonsensical, but so was the original input. * we preserve the invariant that re-parsing constructed node is an identity, and make all the `make_xxx` method return an `Option`. closes #4044 bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
Diffstat (limited to 'crates/ra_hir_def/src/nameres/collector.rs')
0 files changed, 0 insertions, 0 deletions