diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-06-05 16:14:35 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-06-05 16:14:35 +0100 |
| commit | 4029628f15c612182ad9da1c652078f9df62f5cf (patch) | |
| tree | 1cbc69d7d801ca755516daec8894c8e0f20a2769 /crates/ra_hir_def/src/trace.rs | |
| parent | 9c52f527a1cef7d39c2b1c55b49dc5459d392a4d (diff) | |
| parent | bd9d7b6ad885f775df91ff3dfebd8927c8e272b2 (diff) | |
| parent | bc2d1729957a25bf5ee8e2213d07460e22c76def (diff) | |
Merge #4729 #4748
4729: Hover actions r=matklad a=vsrs
This PR adds a `hoverActions` LSP extension and a `Go to Implementations` action as an example:
4748: Add an `ImportMap` and use it to resolve item paths in `find_path` r=matklad a=jonas-schievink
Removes the "go faster" queries I added in https://github.com/rust-analyzer/rust-analyzer/pull/4501 and https://github.com/rust-analyzer/rust-analyzer/pull/4506. I've checked this PR on the rustc code base and the assists are still fast.
This should fix https://github.com/rust-analyzer/rust-analyzer/issues/4515.
Note that this does introduce a change in behavior: We now always refer to items defined in external crates using paths through the external crate. Previously we could also use a local path (if for example the extern crate was reexported locally), as seen in the changed test. If that is undesired I can fix that, but the test didn't say why the previous behavior would be preferable.
Co-authored-by: vsrs <[email protected]>
Co-authored-by: Jonas Schievink <[email protected]>
Co-authored-by: Jonas Schievink <[email protected]>