diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2019-07-29 13:30:39 +0100 |
---|---|---|
committer | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2019-07-29 13:30:39 +0100 |
commit | bf1369cdef1b11ce7ba3a289ae6c4187b6fa5854 (patch) | |
tree | 8df5bee4253cc9f170e2f324062d274871c942bc /crates/ra_parser/src/event.rs | |
parent | 62bdcc0fb2015116316d47d665d504cbe666aaed (diff) | |
parent | b8f95f42e1777d3858c74b45ba8f7a5b5a3cdca8 (diff) |
Merge #1606
1606: Add `if let`, `while let` and match arm inlay hints r=matklad a=SomeoneToIgnore
<img width="693" alt="image" src="https://user-images.githubusercontent.com/2690773/62013363-152f1d80-b19a-11e9-90ea-07568757baa2.png">
Add more inline hints support.
Looks like `while let` type inference support is missing currently, so the corresponding hint tests lack the actual results.
I've also could not find a good way to distinguish between `a` and `b` pats in the following expressions:
`if let Some(Test { a: None, b: y }) = &test {};`
In this case we don't need to add a hint for first pat (`a: None`), since it's matched against the particular enum variant and need a hint for `y`, since it's a new variable.
But both `a` and `b` are `BIND_PAT` with similar contents, so looks like there's nothing I can check for to find any differences.
I don't display any hints for such cases now, to avoid confusion, but would be nice to know if there's a way to fix this behavior.
Co-authored-by: Kirill Bulatov <[email protected]>
Diffstat (limited to 'crates/ra_parser/src/event.rs')
0 files changed, 0 insertions, 0 deletions