Merge #933

933: Check installed extension r=matklad a=c410-f3r

Fixes #918.

Edit: Windows encoding for Unicode is UTF-16 so String::from_utf8 will probably fail unless `Vec<u8>` is already UTF-8 somehow, which I don't know for sure.

Co-authored-by: Caio <[email protected]>

1 files changed, 19 insertions, 2 deletions

diff --git a/crates/tools/src/main.rs b/crates/tools/src/main.rs
index 963ffbe98..4a1b2ff9a 100644
--- a/crates/tools/src/main.rs
+++ b/crates/tools/src/main.rs
@@ -1,7 +1,8 @@
 use clap::{App, SubCommand};
-
+use core::str;
+use failure::bail;
 use tools::{
-    generate, gen_tests, install_format_hook, run, run_rustfmt,
+    generate, gen_tests, install_format_hook, run, run_with_output, run_rustfmt,
     Overwrite, Result, run_fuzzer,
 };
 
@@ -44,5 +45,21 @@ fn install_code_extension() -> Result<()> {
     } else {
         run(r"code --install-extension ./ra-lsp-0.0.1.vsix --force", "./editors/code")?;
     }
+    verify_installed_extensions()?;
+    Ok(())
+}
+
+fn verify_installed_extensions() -> Result<()> {
+    let exts = if cfg!(windows) {
+        run_with_output(r"cmd.exe /c code.cmd --list-extensions", ".")?
+    } else {
+        run_with_output(r"code --list-extensions", ".")?
+    };
+    if !str::from_utf8(&exts.stdout)?.contains("ra-lsp") {
+        bail!(
+            "Could not install the Visual Studio Code extension. Please make sure you \
+             have at least NodeJS 10.x installed and try again."
+        );
+    }
     Ok(())
 }