diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-08-13 11:20:59 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-08-13 11:20:59 +0100 |
| commit | 4abdf323af5bc693f8b9ff3455e19ee1dff572a8 (patch) | |
| tree | 0595d5ba73b7905154d66d6f3a91820711d24db6 /editors/code/src/lsp_ext.ts | |
| parent | de1d93455f85747410efb69c28e0c1379e8e328a (diff) | |
| parent | 0de795fc4c121033890c21ffd41ef9274dc3c74e (diff) | |
Merge #5732
5732: Consider only IdentPats for param name hints r=matklad a=SomeoneToIgnore
Closes https://github.com/rust-analyzer/rust-analyzer/issues/4960
Avoid displaying any param name hints like
<img width="590" alt="image" src="https://user-images.githubusercontent.com/2690773/90071461-47a4ad80-dcfe-11ea-9330-fb4f4e2d1b71.png">
Those hints seem to occupy plenty of space for no apparent benefit, with their destructured content not used in the code with the function hints.
I'm not entirely sure if we should show something else than `IdentPat`s, since I don't understand some of the `Pat` variant meanings:
https://github.com/rust-analyzer/rust-analyzer/blob/a1c187eef3ba08076aedb5154929f7eda8d1b424/crates/syntax/src/ast/generated/nodes.rs#L1336-L1352
Co-authored-by: Kirill Bulatov <[email protected]>
Diffstat (limited to 'editors/code/src/lsp_ext.ts')
0 files changed, 0 insertions, 0 deletions