aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | More orthogonal APIAleksey Kladov2020-11-062-48/+38
| | | | | |
| * | | | | Move int parsing to IntNumber tokenAleksey Kladov2020-11-064-77/+92
| | | | | |
| * | | | | Better importsAleksey Kladov2020-11-061-11/+11
| | | | | |
| * | | | | Generate token for ints and floatsAleksey Kladov2020-11-062-1/+47
|/ / / / /
* | | | | Merge #6479bors[bot]2020-11-061-2/+6
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6479: Ignore RUST_SRC_PATH if it is set to invalid value r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Ignore RUST_SRC_PATH if it is set to invalid valueAleksey Kladov2020-11-061-2/+6
|/ / / / | | | | | | | | | | | | | | | | | | | | Folks report a ton of hard-to-diagnose issues, the solution for which is "unset RUST_SRC_PATH". Let's just ignore RUST_SRC_PATH when it won't work anyway!
* | | | Merge #6470bors[bot]2020-11-051-0/+17
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6470: Restore semantic token flickering workaround removed in #5697 r=kjeremy a=charlespierce Closes #6452 Info ----- * As discussed in #6452, the `Error('busy')` workaround for semantic token flickering was removed because the underlying issue was believed to be fixed in VS Code. * It turns out that the fix isn't yet complete, so this caused flickering of the semantic highlighting when making rapid edits (e.g. typing quickly). * This PR restores that workaround and makes it slightly more robust, covering all areas of semantic token middleware. Changes ----- * Added middleware functions for `provideDocumentSemanticTokens`, `provideDocumentSemanticTokensEdits`, and `provideDocumentRangeSemanticTokens` to match the 3 possible middleware hooks defined in https://github.com/microsoft/vscode-languageserver-node/blob/master/client/src/common/semanticTokens.ts#L33 * Each intercepts a `null` or `undefined` return and throws an error with the message `busy` instead, which prevents the tokens from being removed and re-added (causing the flickering behavior) Tested ----- * Tested locally that the flickering behavior is gone. * There don't appear to be any significant tests of the VS Code plugin side of things, other than that it loads. Is there somewhere I can / should add tests to cover this behavior? Co-authored-by: Charles Pierce <[email protected]>
| * | | | Restore semantic token flickering workaround removed in #5697Charles Pierce2020-11-041-0/+17
| | | | |
* | | | | Merge #6471bors[bot]2020-11-051-6/+6
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6471: cargo update r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | cargo updatekjeremy2020-11-051-6/+6
|/ / / /
* | | | Merge #6468bors[bot]2020-11-041-1/+10
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 6468: Add common issues to the bug report template r=flodiebold a=lnicola Closes #6298 Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Add common issues to the bug report templateLaurențiu Nicola2020-11-041-1/+10
|/ / /
* | | Merge #6467bors[bot]2020-11-044-18/+62
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6467: Don't stack overflow on circular modules r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Don't stack overflow on circular modulesAleksey Kladov2020-11-044-18/+62
| | | | | | | | | | | | | | | | closes #6453
* | | | Merge #6456bors[bot]2020-11-043-41/+137
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6456: Support record variants in extract_struct_from_enum_variant r=matklad a=Veykril As requested :) This also prevents the assist from being disabled if a definition in the value namespace exists with the same name as our new struct since that won't cause a collision #4468 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Support struct variants in extract_struct_from_enum_variantLukas Wirth2020-11-033-49/+101
| | | | |
| * | | | only check type namespace in extract_struct_from_enum_variant for collisionsLukas Wirth2020-11-031-9/+53
| | | | |
* | | | | Merge #6458bors[bot]2020-11-041-38/+114
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6458: Qualify trait impl created by add_custom_impl assist r=matklad a=Veykril When we find at least one trait with the same name as the derive accessible from the current module we now generate a qualified path to that trait in the generated impl. If we don't find any we just do what was done before and emit the trait name in the generated impl. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Qualify trait impl created by add_custom_impl assistLukas Wirth2020-11-031-38/+114
| |/ / /
* | | / Create issue templatesAleksey Kladov2020-11-042-0/+25
| |_|/ |/| |
* | | Merge #6454bors[bot]2020-11-033-136/+137
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 6454: Fix overflow panic in convert_interger_literal assist r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fix overflow panic in convert_interger_literal assistAleksey Kladov2020-11-033-136/+137
| | | | | | | | | | | | | | | | | | | | | | | | | | | This also seizes the opportunity to move integer literal parsing to the syntax crate, were it logically belongs. Note though that this is still done in an ad hoc manner -- we probably should split kitchen sink ast::Literal into a separate APIs for strings, ints, etc
* | | Merge #6287bors[bot]2020-11-035-107/+129
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6287: Don't replace entire module and file nodes when inserting imports r=matklad a=Veykril This change minifies the resulting diff of import insertions by inserting or replacing the produced use tree directly through an `action` return value instead replacing the entire container node. This action has to be applied by the caller now. This unfortunately pulls the `AssistBuilder` into scope of `insert_use` back again but I tried to at least keep it away from the `insert_use` fn itself. I'm open to more/better ideas regarding this :) Fixes #6196 Co-authored-by: Lukas Wirth <[email protected]>
| * | Make insert_use return a SyntaxRewriterLukas Wirth2020-11-025-107/+129
| | |
* | | Merge #6401bors[bot]2020-11-031-2/+23
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6401: Only show `self` ident when showing parameter self hints r=matklad a=Veykril This just hints all self parameters with the `self` token, this is therefor equal to how all other parameters are displayed, but given the self param special in how its defined in a function signature it might make sense to keep the `&`/`&mut` parts as well as emitting those tokens for explict `Self` types that are taken by ref like `self: &Rc<Self>`? Fixes #6400 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Only show `self` ident when showing parameter self hintsLukas Wirth2020-11-021-2/+23
| |/ /
* | | Merge #6435bors[bot]2020-11-031-2/+15
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 6435: Test Fixture ExplicitRoot + ModuleResolutionRelativePathOutsideRoot. r=matklad a=rickvanprim Updates `module_resolution_relative_path_outside_root` test to check valid paths outside of the root, by moving the root to a subpath so that paths outside of it are possible. If this would be more appropriate as a new test, or if the original check for an invalid path should be left, I'm happy to update. Co-authored-by: James Leitch <[email protected]>
| * | Feedback.James Leitch2020-11-023-8/+2
| | |
| * | Test Fixture ExplicitRoot + ModuleResolutionRelativePathOutsideRoot.James Leitch2020-11-023-3/+22
| | |
* | | Merge #6450bors[bot]2020-11-031-0/+60
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6450: Textmate grammar: Distinguish turbofish function calls from namespaces r=dustypomerleau a=dustypomerleau Fixes #6446. Co-authored-by: Dusty Pomerleau <[email protected]>
| * | | fix: distinguish turbofish function calls from namespacesDusty Pomerleau2020-11-031-0/+60
|/ / /
* | | Merge #6430bors[bot]2020-11-0310-1355/+1781
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6430: Move completions rendering into a separate module r=popzxc a=popzxc This PR extracts rendering-related things from `Completions` structure to the new `render` module. `render` module declares a `Render` structure (which is a generic renderer interface), `RenderContext` (interface for data/methods not required for completions generating, but required for rendering), and a bunch of smaller `*Render` structures which encapsulate logic behind rendering a certain item. This is just a step in full separation direction, since the following this are still to be done: - Move some data from `CompletionContext` to the `RenderContext`; - Forbid any kind of rendering outside of `render` module; - Extract score computing into a separate module. This PR is already pretty big, so not to make it even harder to review I decided to split this process into several subsequent PRs. Co-authored-by: Igor Aleksanov <[email protected]>
| * | | Remove intra-crate facade from completionsIgor Aleksanov2020-11-032-10/+16
| | | |
| * | | Get rid of do-er antipatternIgor Aleksanov2020-11-037-45/+100
| | | |
| * | | Provide only explicit constructor for RenderContextIgor Aleksanov2020-11-032-16/+14
| | | |
| * | | Add doc-comments to the new filesIgor Aleksanov2020-11-036-1/+17
| | | |
| * | | Make structures order more logical in render.rsIgor Aleksanov2020-11-031-5/+5
| | | |
| * | | Move rendering tests to the render moduleIgor Aleksanov2020-11-036-1095/+1163
| | | |
| * | | Add TypeAliasRenderIgor Aleksanov2020-11-034-19/+54
| | | |
| * | | Add ConstRenderIgor Aleksanov2020-11-035-28/+65
| | | |
| * | | Introduce render moduleIgor Aleksanov2020-11-037-246/+457
| | |/ | |/|
* | | Merge #6447bors[bot]2020-11-031-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6447: Textmate grammar: allow function declarations without curly brackets r=lnicola a=dustypomerleau Functions inside trait declarations can break subsequent highlighting, because they have no curly brackets. In a case such as: ```rust pub trait Summary { fn summarize(&self) -> String; } ``` the scope `meta.function.definition.rust` will continue past the end of the block looking for `{` after `fn`. This PR allows `meta.function.definition.rust` to terminate with `;` in these cases. Co-authored-by: Dusty Pomerleau <[email protected]>
| * | | fix: allow functions without curly bracketsDusty Pomerleau2020-11-031-1/+1
| |/ /
* | | Merge #6421bors[bot]2020-11-031-30/+96
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6421: Check for allow(..) attributes in case check diagnostic r=popzxc a=popzxc Resolves #6348 This is not a full-fledged solution, as it doesn't looks up for parent elements (e.g. function -> module -> parent module -> crate root), but it does at least checks attributes of item being checked. I played a bit with code, and it seems that implementing a proper solution (which will also check for `deny` / `warn` attributes overriding values for `allow`s from above). So, this solution should fix all the macros which intentionally do "weird" naming and wrap it with `allow`, such as `lazy_static`. cc @ArifRoktim Co-authored-by: Igor Aleksanov <[email protected]>
| * | Improve decl_check module readabilityIgor Aleksanov2020-11-031-6/+6
| | |
| * | Remove numbers from comments in decl_check.rsIgor Aleksanov2020-11-031-15/+15
| | |
| * | Check for allow(..) attributes for case diagnosticIgor Aleksanov2020-11-031-25/+91
|/ /
* | Merge #6445bors[bot]2020-11-021-14/+14
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6445: Fix coalescing of prime_caches updates r=jonas-schievink a=jonas-schievink The previous implementation could try to create a progress bar when one was already registered. bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | Fix coalescing of prime_caches updatesJonas Schievink2020-11-021-14/+14
| | | | | | | | | | | | | | | The previous implementation could try to create a progress bar when one was already registered
* | | Merge #6365bors[bot]2020-11-022-41/+121
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6365: Do insertion lookahead in algo::diff r=matklad a=Veykril This is the last blocker for #6287 after this I can update that PR to properly fix things through using `SyntaxRewriter`. This PR also shuffles tests around a bit and adds some more. Ideally this is just a hack until we implement a "proper" diff algorithm that approximates a minimal diff. Maybe something like [gumtree](https://github.com/GumTreeDiff/gumtree)? Co-authored-by: Lukas Wirth <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-11 20:04:20 +0000