aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #4114bors[bot]2020-04-2410-333/+329
|\ | | | | | | | | | | | | | | | | 4114: Refactor completion sorting r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Don't set sortTextAleksey Kladov2020-04-242-18/+10
| | | | | | | | | | | | I might be reading this wrong, but it looks like we are setting it to essentially arbitrary string at the moment, as there are no defined order on the items in the *set* of completions.
| * Add test marksAleksey Kladov2020-04-242-0/+6
| |
| * Introduce ActiveParameterAleksey Kladov2020-04-245-30/+35
| |
| * Move tests to where they belongAleksey Kladov2020-04-242-231/+231
| |
| * RefactorAleksey Kladov2020-04-241-24/+18
| |
| * Restore CompletionItem immutabilityAleksey Kladov2020-04-242-31/+23
| |
| * More functionalAleksey Kladov2020-04-242-11/+18
| |
| * MoveAleksey Kladov2020-04-231-9/+9
|/
* Merge #4106bors[bot]2020-04-232-1/+42
|\ | | | | | | | | | | | | | | | | | | 4106: Fix wrong substitution code r=matklad a=flodiebold We need to shift in when we're substituting inside a binder. This should fix #4053 (it doesn't fix the occasional overflow that also occurs on the Diesel codebase though). Co-authored-by: Florian Diebold <[email protected]>
| * Fix wrong substitution codeFlorian Diebold2020-04-232-1/+42
| | | | | | | | | | | | | | We need to shift in when we're substituting inside a binder. This should fix #4053 (it doesn't fix the occasional overflow that also occurs on the Diesel codebase though).
* | Merge #3954bors[bot]2020-04-239-40/+412
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3954: Improve autocompletion by looking on the type and name r=matklad a=bnjjj This tweet (https://twitter.com/tjholowaychuk/status/1248918374731714560) gaves me the idea to implement that in rust-analyzer. Basically for this first example I made some examples when we are in a function call definition. I look on the parameter list to prioritize autocompletions for the same types and if it's the same type + the same name then it's displayed first in the completion list. So here is a draft, first step to open a discussion and know what you think about the implementation. It works (cf tests) but maybe I can make a better implementation at some places. Be careful the code needs some refactoring to be better and concise. PS: It was lot of fun writing this haha Co-authored-by: Benjamin Coenen <[email protected]>
| * | Improve autocompletion by looking on the type and nameBenjamin Coenen2020-04-212-5/+6
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | Improve autocompletion by looking on the type and nameBenjamin Coenen2020-04-211-3/+1
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-04-2160-422/+1076
| |\ \
| * | | Improve autocompletion by looking on the type and nameBenjamin Coenen2020-04-214-48/+47
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-04-1830-183/+705
| |\ \ \
| * | | | feat: improve dot completions with scoringBenjamin Coenen2020-04-171-5/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | revert tidy tests changesBenjamin Coenen2020-04-171-3/+3
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-04-1751-364/+1126
| |\ \ \ \
| * | | | | feat: improve dot completions with scoringBenjamin Coenen2020-04-174-77/+52
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | feat: improve dot completions with scoringBenjamin Coenen2020-04-167-113/+103
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | feat: improve dot completions in a struct literal expressionBenjamin Coenen2020-04-154-31/+196
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | add sort_text to sort in editor viewBenjamin Coenen2020-04-142-8/+12
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-04-1425-145/+557
| |\ \ \ \ \
| * | | | | | Improve autocompletion by looking on the type and name, change ↵Benjamin Coenen2020-04-124-27/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | implementation, include sort in Completions struct Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | | Improve autocompletion by looking on the type and nameBenjamin Coenen2020-04-11288-5418/+3920
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | | | Improve autocompletion by looking on the type and nameBenjamin Coenen2020-04-116-30/+194
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| | | | | | | |
| \ \ \ \ \ \ \
*-. \ \ \ \ \ \ \ Merge #4111 #4112bors[bot]2020-04-233-5/+61
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4111: Record definitions in `extern` blocks r=jonas-schievink a=jonas-schievink Enables completion of extern functions and statics. Closes https://github.com/rust-analyzer/rust-analyzer/issues/3711 4112: Add Launch configuration for release build r=matklad a=jonas-schievink The debug build takes very long until I can test anything useful, with the release build it's much quicker. Add another Run configuration for it. Co-authored-by: Jonas Schievink <[email protected]>
| | * | | | | | | | Add Launch configuration for release buildJonas Schievink2020-04-231-2/+23
| |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Merge #4110bors[bot]2020-04-231-4/+0
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4110: minor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | | | minorAleksey Kladov2020-04-231-4/+0
| | | | | | | | | |
| | * | | | | | | | Record definitions in `extern` blocksJonas Schievink2020-04-232-3/+38
| |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Merge #4108bors[bot]2020-04-233-24/+40
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4108: Fully get rid of SyntaxNodePtr::range r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | | Fully get rid of SyntaxNodePtr::rangeAleksey Kladov2020-04-233-24/+40
| | |_|_|_|_|_|/ | |/| | | | | |
* | | | | | | | Merge #4107bors[bot]2020-04-231-5/+0
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4107: Disable onEnter command by default r=matklad a=matklad We are transitioning from experimental to production-ready stance, so it makes sense to disable potentially disruptive features by default. bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | Disable onEnter command by defaultAleksey Kladov2020-04-231-5/+0
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are transitioning from experimental to production-ready stance, so it makes sense to disable potentially disruptive features by default.
* | | | | | | Merge #4102bors[bot]2020-04-233-11/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4102: Cleanup proc_macro config r=matklad a=matklad In general, there should be no reason to call `.to_string_lossy`. If you want to display the path, use `.display()`. If you want to pass the path to an OS API (like std::process::Command) than use `PathBuf` or `OsString`. bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | Cleanup proc_macro configAleksey Kladov2020-04-233-11/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In general, there should be no reason to call `.to_string_lossy`. If you want to display the path, use `.display()`. If you want to pass the path to an OS API (like std::process::Command) than use `PathBuf` or `OsString`.
* | | | | | | | Merge #4100bors[bot]2020-04-231-1/+1
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4100: Bump required rust to 1.43 r=matklad a=kjeremy This only impacts source builds Co-authored-by: kjeremy <[email protected]>
| * | | | | | | Bump required rust to 1.43kjeremy2020-04-231-1/+1
| | | | | | | |
* | | | | | | | Merge #4065bors[bot]2020-04-232-7/+217
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4065: Complete unqualified enum names in patterns and expressions r=matklad a=nathanwhit This PR implements the completion described in #4014. The result looks like so for patterns: <img width="542" alt="Screen Shot 2020-04-20 at 3 53 55 PM" src="https://user-images.githubusercontent.com/17734409/79794010-8f529400-831f-11ea-9673-f838aa9bc962.png"> and for `expr`s: <img width="620" alt="Screen Shot 2020-04-21 at 3 51 24 PM" src="https://user-images.githubusercontent.com/17734409/79908784-d73ded80-83e9-11ea-991d-921f0cb27e6f.png"> I'm not confident that the completion text itself is very robust, as it will unconditionally add completions for enum variants with the form `Enum::Variant`. This means (I believe) it would still suggest `Enum::Variant` even if the local name is changed i.e. `use Enum as Foo` or the variants are brought into scope such as through `use Enum::*`. Co-authored-by: nathanwhit <[email protected]>
| * | | | | | | Update tests to reflect new completionsnathanwhit2020-04-221-1/+1
| | | | | | | |
| * | | | | | | Add tests for enum completionnathanwhit2020-04-221-0/+178
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds tests for completion of enum variants in match arms, if-let statements, and basic expressions.
| * | | | | | | Complete unqualified enum variants when possiblenathanwhit2020-04-221-5/+26
| | | | | | | |
| * | | | | | | Add utility fn for expected type of a nodenathanwhit2020-04-221-1/+12
| | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Adds `expected_type_of` to `CompletionContext` to return the expected type of a node, if it is known.
* | | | | | | Merge #4099bors[bot]2020-04-233-3/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4099: Remove SyntaxPtr::range from more places r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | Remove SyntaxPtr::range from more placesAleksey Kladov2020-04-233-3/+8
|/ / / / / / /
* | | | | | | Merge #4093bors[bot]2020-04-231-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4093: Simplify config r=matklad a=Veetaha Co-authored-by: veetaha <[email protected]>
| * | | | | | | Simplify configveetaha2020-04-221-1/+1
| | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-01 20:48:56 +0000