aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge #5554bors[bot]2020-07-291-9/+85
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5554: Fix remove_dbg r=matklad a=petr-tik Closes #5129 Addresses two issues: - keep the parens from dbg!() in case the call is chained or there is semantic difference if parens are excluded - Exclude the semicolon after the dbg!(); by checking if it was accidentally included in the macro_call investigated, but decided against: fix ast::MacroCall extraction to never include semicolons at the end - this logic lives in rowan. Defensively shorten the macro_range if there is a semicolon token. Deleted unneccessary temp variable macro_args Renamed macro_content to "paste_instead_of_dbg", because it isn't a simple extraction of text inside dbg!() anymore Co-authored-by: petr-tik <[email protected]>
| * | | Addressed code reviewpetr-tik2020-07-291-27/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | replaced match with let-if variable assignment removed the unnecessary semicolon_on_end variable converted all code and expected test variables to raw strings and inlined them in asserts
| * | | Fixed #5129petr-tik2020-07-271-8/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Addresses two issues: - keep the parens from dbg!() in case the call is chained or there is semantic difference if parens are excluded - Exclude the semicolon after the dbg!(); by checking if it was accidentally included in the macro_call investigated, but decided against: fix ast::MacroCall extraction to never include semicolons at the end - this logic lives in rowan. Defensively shorten the macro_range if there is a semicolon token. Deleted unneccessary temp variable macro_args Renamed macro_content to "paste_instead_of_dbg", because it isn't a simple extraction of text inside dbg!() anymore
| * | | Make all test fn names consistent in remove_dbgpetr-tik2020-07-271-3/+29
| | | |
| * | | Added failing testspetr-tik2020-07-271-0/+21
| | | |
* | | | Merge #5563bors[bot]2020-07-292-6/+7
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 5563: Check all targets for package-level tasks r=matklad a=SomeoneToIgnore When invoking "Select Runnable" with the caret on a runnable with a specific target (test, bench, binary), append the corresponding argument for the `cargo check -p` module runnable. Co-authored-by: Kirill Bulatov <[email protected]>
| * | | Run package-specific cargo check and test for all targetsKirill Bulatov2020-07-292-6/+7
| | | |
* | | | Merge #5576bors[bot]2020-07-294-12/+11
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | 5576: cargo_metadata 0.11.1 and cargo update r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | cargo_metadata 0.11.1 and cargo updatekjeremy2020-07-294-12/+11
|/ / /
* | | Merge #5574bors[bot]2020-07-297-98/+44
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5574: Replace rand with oorandom r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Update crates/rust-analyzer/src/cli/analysis_stats.rsAleksey Kladov2020-07-291-1/+1
| | | | | | | | | | | | Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | Replace rand with oorandomAleksey Kladov2020-07-297-98/+44
| | | |
* | | | Merge #5573bors[bot]2020-07-295-28/+28
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5573: Rename NomialDef -> AdtDef r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Rename NomialDef -> AdtDefAleksey Kladov2020-07-295-28/+28
| | | |
* | | | Merge #5572bors[bot]2020-07-299-4192/+1591
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5572: Switch to ungrammar from ast_src r=matklad a=matklad The primary advantage of ungrammar is that it (eventually) allows one to describe concrete syntax tree structure -- with alternatives and specific sequence of tokens & nodes. That should be re-usable for: * generate `make` calls * Rust reference * Hypothetical parser's evented API We loose doc comments for the time being unfortunately. I don't think we should add support for doc comments to ungrammar -- they'll make grammar file hard to read. We might supply docs as out-of band info, or maybe just via a reference, but we'll think about that once things are no longer in flux bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Switch to ungrammar from ast_srcAleksey Kladov2020-07-299-4192/+1591
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The primary advantage of ungrammar is that it (eventually) allows one to describe concrete syntax tree structure -- with alternatives and specific sequence of tokens & nodes. That should be re-usable for: * generate `make` calls * Rust reference * Hypothetical parser's evented API We loose doc comments for the time being unfortunately. I don't think we should add support for doc comments to ungrammar -- they'll make grammar file hard to read. We might supply docs as out-of band info, or maybe just via a reference, but we'll think about that once things are no longer in flux
* | | Merge #5570bors[bot]2020-07-292-49/+0
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5570: Dead code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Dead codeAleksey Kladov2020-07-292-49/+0
|/ / /
* | | Merge #5569bors[bot]2020-07-292-4/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5569: Remove dead code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Remove dead codeAleksey Kladov2020-07-292-4/+1
|/ / /
* | | Merge #5568bors[bot]2020-07-292-54/+0
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | 5568: Remove dead code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Remove dead codeAleksey Kladov2020-07-292-54/+0
|/ /
* | Merge #5566bors[bot]2020-07-292-1925/+1934
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5566: Owned AST IR r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Owned AST IRAleksey Kladov2020-07-292-1925/+1934
| | |
* | | Merge #5564bors[bot]2020-07-2911-55/+186
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 5564: SSR: Restrict to current selection if any r=davidlattimore a=davidlattimore The selection is also used to avoid unnecessary work, but only to the file level. Further restricting unnecessary work is left for later. Co-authored-by: David Lattimore <[email protected]>
| * | SSR: Rename position and lookup_context to resolve_contextDavid Lattimore2020-07-292-6/+6
| | |
| * | SSR: Restrict to current selection if anyDavid Lattimore2020-07-2910-50/+181
| | | | | | | | | | | | | | | The selection is also used to avoid unnecessary work, but only to the file level. Further restricting unnecessary work is left for later.
* | | Merge #5565bors[bot]2020-07-292-1/+62
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5565: SSR: Don't mix non-path-based rules with path-based r=matklad a=davidlattimore If any rules contain paths, then we reject any rules that don't contain paths. Allowing a mix leads to strange semantics, since the path-based rules only match things where the path refers to semantically the same thing, whereas the non-path-based rules could match anything. Specifically, if we have a rule like `foo ==>> bar` we only want to match the `foo` that is in the current scope, not any `foo`. However "foo" can be parsed as a pattern (BIND_PAT -> NAME -> IDENT). Allowing such a rule through would result in renaming everything called `foo` to `bar`. It'd also be slow, since without a path, we'd have to use the slow-scan search mechanism. Co-authored-by: David Lattimore <[email protected]>
| * | | SSR: Don't mix non-path-based rules with path-basedDavid Lattimore2020-07-292-1/+62
| |/ / | | | | | | | | | If any rules contain paths, then we reject any rules that don't contain paths. Allowing a mix leads to strange semantics, since the path-based rules only match things where the path refers to semantically the same thing, whereas the non-path-based rules could match anything. Specifically, if we have a rule like `foo ==>> bar` we only want to match the `foo` that is in the current scope, not any `foo`. However "foo" can be parsed as a pattern (BIND_PAT -> NAME -> IDENT). Allowing such a rule through would result in renaming everything called `foo` to `bar`. It'd also be slow, since without a path, we'd have to use the slow-scan search mechanism.
* | | Merge #5561bors[bot]2020-07-291-54/+110
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5561: Allow running more tests at once via the module runners r=matklad a=SomeoneToIgnore Sometimes I group tests into submodules located in the root `#[cfg(test)]` crate and want to (re)run them all at once. This PR adds more test runnables to allow running all tests in the file via a module runner. Not all possible module runners are added, to avoid displaying too many code lens. before: <img width="306" alt="before" src="https://user-images.githubusercontent.com/2690773/88724886-e4c6ea00-d133-11ea-9d80-082bb610d422.png"> after (`nested_tests_0` got the runnable, `root_tests` had not): <img width="300" alt="after" src="https://user-images.githubusercontent.com/2690773/88724896-e85a7100-d133-11ea-99ee-689126679cbc.png"> Co-authored-by: Kirill Bulatov <[email protected]>
| * | Allow running more tests at onceKirill Bulatov2020-07-281-54/+110
|/ /
* | Merge #5560bors[bot]2020-07-283-7/+8
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5560: Fix nameref parsing r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fix nameref parsingAleksey Kladov2020-07-283-7/+8
|/ /
* | Merge #5555bors[bot]2020-07-281-1/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5555: Bump test timeout for macs r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Bump test timeout for macsAleksey Kladov2020-07-281-1/+2
|/ /
* | Merge #5547bors[bot]2020-07-271-1/+13
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5547: Fold multiline fn parameters r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fold multiline fn parametersAleksey Kladov2020-07-271-1/+13
| | |
* | | Merge #5532bors[bot]2020-07-272-23/+31
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5532: Restore line index optimization for edits r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | Restore line index micro-optimizationLaurențiu Nicola2020-07-252-23/+31
| | | |
* | | | Merge #5528bors[bot]2020-07-271-0/+10
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 5528: README: Add some instructions for running typescript tests and linter. r=matklad a=davidlattimore Co-authored-by: David Lattimore <[email protected]>
| * | | README: Add some instructions for running typescript tests and linter.David Lattimore2020-07-251-0/+10
| | | |
* | | | Merge #5539bors[bot]2020-07-273-27/+103
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5539: SSR: Fix path resolution of locals in current scope r=matklad a=davidlattimore Co-authored-by: David Lattimore <[email protected]>
| * | | | SSR: Fix for path resolution of localsDavid Lattimore2020-07-262-0/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It seems that Semantics::scope, if given a statement node, won't resolve locals that were defined in the current scope, only in parent scopes. Not sure if this is intended / expected behavior, but we work around it for now by finding another nearby node to use as the scope (e.g. the expression inside the EXPR_STMT).
| * | | | SSR: Move more resolution-related code into the resolving moduleDavid Lattimore2020-07-262-27/+38
| | | | |
* | | | | Merge #5541bors[bot]2020-07-271-4/+278
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5541: add completion for rustc lints r=matklad a=Emilgardis This is a very naive approach to provide completions for lints. Preferably, this would pull from current `rustup which rustc` via `rustc -W help <crate>`, but currently `rustc` only provides human output for lints. ![image](https://user-images.githubusercontent.com/1502855/88492913-90dec880-cfae-11ea-89d8-2b494951b20c.png) also, clippy would be really nice but I feel like for that ra should really pull from clippy Co-authored-by: Emil Gardström <[email protected]>
| * | | | | add completion for rustc lintsEmil Gardström2020-07-271-4/+278
| |/ / / /
* | | | | Merge #5543bors[bot]2020-07-271-12/+12
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5543: :arrow_up: deps r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | :arrow_up: depsAleksey Kladov2020-07-271-12/+12
|/ / / /
* | | | Merge #5538bors[bot]2020-07-261-0/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5538: Report type errors in metrics r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Report type errors in metricsAleksey Kladov2020-07-261-0/+4
|/ / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-23 18:51:35 +0000