Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Apply some clippy suggestions | Clemens Wasser | 2021-06-21 | 1 | -23/+19 |
| | |||||
* | Filter out non-type completions in the respective completions modules instead | Lukas Wirth | 2021-06-16 | 1 | -12/+0 |
| | |||||
* | Merge #9260 | bors[bot] | 2021-06-14 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | | | 9260: tree-wide: make rustdoc links spiky so they are clickable r=matklad a=lf- Rustdoc was complaining about these while I was running with --document-private-items and I figure they should be fixed. Co-authored-by: Jade <[email protected]> | ||||
| * | tree-wide: make rustdoc links spiky so they are clickable | Jade | 2021-06-14 | 1 | -1/+1 |
| | | |||||
* | | internal: kill diagnostic sink | Aleksey Kladov | 2021-06-13 | 1 | -22/+6 |
| | | |||||
* | | internal: use cov-mark rather than bailing out diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -22/+6 |
| | | |||||
* | | internal: refactor missing match arms diagnostics | Aleksey Kladov | 2021-06-13 | 1 | -5/+8 |
| | | |||||
* | | internal: refactor incorrect case diagnostics | Aleksey Kladov | 2021-06-13 | 1 | -8/+10 |
| | | |||||
* | | internal: refactor find_map diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -4/+7 |
| | | |||||
* | | internal: refactor missing or or some diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -5/+1 |
| | | |||||
* | | internal: refactor remove this semicolon diagnostics | Aleksey Kladov | 2021-06-13 | 1 | -4/+1 |
| | | |||||
* | | internal: refactor mismatched args count diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -6/+3 |
| | | |||||
* | | internal: refactor missing unsafe diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -3/+1 |
| | | |||||
* | | internal: refactor BreakOutsideOfLoop diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -2/+2 |
| | | |||||
* | | internal: refactor NoSuchField diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -1/+1 |
| | | |||||
* | | internal: refactor unimplemented builtin macro diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -2/+6 |
| | | |||||
* | | internal: refactor macro error | Aleksey Kladov | 2021-06-13 | 1 | -9/+11 |
| | | |||||
* | | internal: refactor unresolved proc macro diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -18/+15 |
| | | |||||
* | | internal: refactor inactive code diagnostics | Aleksey Kladov | 2021-06-13 | 1 | -12/+12 |
| | | |||||
* | | internal: refactor unresolved macro call diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -12/+10 |
| | | |||||
* | | internal: refactor unresolved import diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -1/+4 |
| | | |||||
* | | internal: refactor unresolved extern crate diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -4/+6 |
| | | |||||
* | | internal: unified missing fields diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -57/+60 |
| | | |||||
* | | internal: move missing_fields diagnostics | Aleksey Kladov | 2021-06-13 | 1 | -15/+18 |
| | | |||||
* | | internal: start new diagnostics API | Aleksey Kladov | 2021-06-13 | 1 | -14/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the moment, this moves only a single diagnostic, but the idea is reafactor the rest to use the same pattern. We are going to have a single file per diagnostic. This file will define diagnostics code, rendering range and fixes, if any. It'll also have all of the tests. This is similar to how we deal with assists. After we refactor all diagnostics to follow this pattern, we'll probably move them to a new `ide_diagnostics` crate. Not that we intentionally want to test all diagnostics on this layer, despite the fact that they are generally emitted in the guts on the compiler. Diagnostics care to much about the end presentation details/fixes to be worth-while "unit" testing. So, we'll unit-test only the primary output of compilation process (types and name res tables), and will use integrated UI tests for diagnostics. | ||||
* | | clippy::clone_on_copy | Maan2003 | 2021-06-13 | 1 | -1/+1 |
| | | |||||
* | | clippy::redudant_borrow | Maan2003 | 2021-06-13 | 1 | -4/+4 |
| | | |||||
* | | internal: move diagnostics infra to hir | Aleksey Kladov | 2021-06-12 | 1 | -14/+18 |
| | | |||||
* | | Move some hir_ty diagnostics to hir | Aleksey Kladov | 2021-06-12 | 1 | -12/+163 |
| | | |||||
* | | minor: optimize | Aleksey Kladov | 2021-06-12 | 1 | -3/+4 |
| | | | | | | | | | | We shouldn't be looking at the source map unless we actually have diagnostics. | ||||
* | | internal: move missing unsafe diagnostic to hir | Aleksey Kladov | 2021-06-12 | 1 | -4/+16 |
| | | |||||
* | | internal: move inference diagnostics to hir | Aleksey Kladov | 2021-06-12 | 1 | -2/+20 |
| | | |||||
* | | Merge #9218 | bors[bot] | 2021-06-11 | 1 | -0/+14 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | 9218: Item search now respects trait impl items r=Veykril a=Veykril Fixes #2977 Co-authored-by: Lukas Wirth <[email protected]> | ||||
| * | | Item search now respects trait impl items | Lukas Wirth | 2021-06-11 | 1 | -0/+14 |
| |/ | |||||
* / | Add more profiling for flyimports | Kirill Bulatov | 2021-06-10 | 1 | -0/+4 |
|/ | |||||
* | Implement dummy expansions for builtin attributes | Lukas Wirth | 2021-06-09 | 1 | -0/+1 |
| | |||||
*-. | Merge #9181 #9182 | bors[bot] | 2021-06-08 | 1 | -0/+19 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9181: Don't complete values in type position r=jonas-schievink a=Veykril Will add some proper tests in a bit 9182: fix: don't complete derive macros as fn-like macros r=jonas-schievink a=jonas-schievink Part of https://github.com/rust-analyzer/rust-analyzer/issues/8518 bors r+ Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Jonas Schievink <[email protected]> | ||||
| | * | fix: don't complete derive macros as fn-like macros | Jonas Schievink | 2021-06-08 | 1 | -0/+7 |
| |/ |/| | |||||
| * | Don't complete values in type position | Lukas Wirth | 2021-06-08 | 1 | -0/+12 |
|/ | |||||
* | feat: goto definition on an impl fn goes to that fn in the trait | Jade | 2021-06-07 | 1 | -4/+5 |
| | | | | | | | e.g. if you have a trait T and `impl T for S` for some struct, if you goto definition on some function name inside the impl, it will go to the definition of that function inside the `trait T` block, rather than the current behaviour of not going anywhere at all. | ||||
* | Expand procedural attribute macros | Jonas Schievink | 2021-06-03 | 1 | -1/+15 |
| | |||||
* | Diagnose unimplemented built-in macros | Jonas Schievink | 2021-05-30 | 1 | -2/+10 |
| | |||||
* | Thread proc-macro types through the HIR | Jonas Schievink | 2021-05-29 | 1 | -5/+13 |
| | |||||
* | Stop expanding UseTrees during ItemTree lowering | Jonas Schievink | 2021-05-26 | 1 | -20/+6 |
| | |||||
* | internal: move diagnostics to hir | Aleksey Kladov | 2021-05-25 | 1 | -4/+172 |
| | | | | | | | | | | | | | | | | | | | | | | | The idea here is to eventually get rid of `dyn Diagnostic` and `DiagnosticSink` infrastructure altogether, and just have a `enum hir::Diagnostic` instead. The problem with `dyn Diagnostic` is that it is defined in the lowest level of the stack (hir_expand), but is used by the highest level (ide). As a first step, we free hir_expand and hir_def from `dyn Diagnostic` and kick the can up to `hir_ty`, as an intermediate state. The plan is then to move DiagnosticSink similarly to the hir crate, and, as final third step, remove its usage from the ide. One currently unsolved problem is testing. You can notice that the test which checks precise diagnostic ranges, unresolved_import_in_use_tree, was moved to the ide layer. Logically, only IDE should have the infra to render a specific range. At the same time, the range is determined with the data produced in hir_def and hir crates, so this layering is rather unfortunate. Working on hir_def shouldn't require compiling `ide` for testing. | ||||
* | Merge #8942 | bors[bot] | 2021-05-25 | 1 | -32/+1 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | 8942: Add `library` semantic token modifier to items from other crates r=arzg a=arzg Closes #5772. A lot of code here is pretty repetitive; please let me know if you have any ideas how to improve it, or whether it’s fine as-is. Side-note: How can I add tests for this? I don’t see a way for the test Rust code in `test_highlighting` to reference other crates to observe the new behaviour. Co-authored-by: Aramis Razzaghipour <[email protected]> | ||||
| * | Remove hir krate methods | Aramis Razzaghipour | 2021-05-24 | 1 | -48/+0 |
| | | |||||
| * | Add highlighting of items from other crates | Aramis Razzaghipour | 2021-05-24 | 1 | -0/+17 |
| | | |||||
* | | Get rid of field_type again | Florian Diebold | 2021-05-23 | 1 | -14/+1 |
| | | |||||
* | | Infer correct expected type for generic struct fields | Florian Diebold | 2021-05-23 | 1 | -3/+15 |
|/ |