Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Rename ra_prof -> profile | Aleksey Kladov | 2020-08-12 | 3 | -8/+5 |
| | |||||
* | Merge #5553 | bors[bot] | 2020-08-12 | 2 | -15/+7 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5553: Add fix ranges for diagnostics r=matklad a=SomeoneToIgnore A follow-up of https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Less.20red.20in.20the.20code Now diagnostics can apply fixes in a range that's different from the range used to highlight the diagnostics. Previous logic did not consider the fix range, having both ranges equal, which could cause a lot of red noise in the editor. Now, the fix range gets used with the fix, the diagnostics range is used for everything else which allows to improve the error highlighting. before: <img width="191" alt="image" src="https://user-images.githubusercontent.com/2690773/88590727-df9a6a00-d063-11ea-97ed-9809c1c5e6e6.png"> after: <img width="222" alt="image" src="https://user-images.githubusercontent.com/2690773/88590734-e1fcc400-d063-11ea-9b7c-25701cbd5352.png"> `MissingFields` and `MissingPatFields` diagnostics now have the fix range as `ast::RecordFieldList` of the expression with an error (as it was before this PR), and the diagnostics range as a `ast::Path` of the expression, if it's present (do you have any example of `ast::Expr::RecordLit` that has no path btw?). The rest of the diagnostics have both ranges equal, same as it was before this PR. Co-authored-by: Kirill Bulatov <[email protected]> | ||||
| * | Better naming and docs | Kirill Bulatov | 2020-08-11 | 1 | -4/+4 |
| | | |||||
| * | Improve the ide diagnostics trait API | Kirill Bulatov | 2020-08-11 | 1 | -4/+1 |
| | | |||||
| * | Move the DiagnosticsWithFix trait on the ide level | Kirill Bulatov | 2020-08-11 | 2 | -12/+4 |
| | | |||||
| * | Make the fix AST source Optional | Kirill Bulatov | 2020-08-11 | 2 | -5/+5 |
| | | |||||
| * | Refactor the diagnostics | Kirill Bulatov | 2020-08-11 | 1 | -18/+10 |
| | | |||||
| * | Better naming | Kirill Bulatov | 2020-08-11 | 1 | -0/+11 |
| | | |||||
* | | Merge #4743 | bors[bot] | 2020-08-12 | 3 | -2/+117 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4743: Add tracking of packed repr, use it to highlight unsafe refs r=matklad a=Nashenas88 Taking a reference to a misaligned field on a packed struct is an unsafe operation. Highlight that behavior. Currently, the misaligned part isn't tracked, so this highlight is a bit too aggressive. Fixes #4600 Co-authored-by: Paul Daniel Faria <[email protected]> Co-authored-by: Paul Daniel Faria <[email protected]> Co-authored-by: Paul Daniel Faria <[email protected]> | ||||
| * | | Fix type names broken by rebase, redo expected test because of rebase | Paul Daniel Faria | 2020-08-10 | 1 | -9/+13 |
| | | | |||||
| * | | Move unsafe semantics methods into `SemanticsImpl` and reference them in ↵ | Paul Daniel Faria | 2020-08-10 | 1 | -71/+83 |
| | | | | | | | | | | | | `Semantics` | ||||
| * | | Return bool from is_unsafe_method_call and cleanup usages | Paul Daniel Faria | 2020-08-10 | 1 | -19/+19 |
| | | | |||||
| * | | Move semantic logic into Semantics, fix missing tag for safe amp operator, ↵ | Paul Daniel Faria | 2020-08-10 | 1 | -35/+75 |
| | | | | | | | | | | | | using functional methods rather than clunky inline closure | ||||
| * | | Move unsafe packed ref logic to Semantics, use `Attrs::by_key` to simplify ↵ | Paul Daniel Faria | 2020-08-10 | 1 | -0/+41 |
| | | | | | | | | | | | | repr attr lookup | ||||
| * | | Revert function structs back to using bool to track self param, use first ↵ | Paul Daniel Faria | 2020-08-10 | 2 | -4/+3 |
| | | | | | | | | | | | | param for self information in syntax highlighting instead | ||||
| * | | Unsafe borrow of packed fields: account for borrow through ref binding, auto ↵ | Paul Daniel Faria | 2020-08-10 | 1 | -2/+3 |
| | | | | | | | | | | | | ref function calls | ||||
| * | | Remove token tree from ReprKind::Other variant, expose ReprKind higher, ↵ | Paul Daniel Faria | 2020-08-10 | 1 | -3/+3 |
| | | | | | | | | | | | | remove debug println. | ||||
| * | | Add tracking of packed repr, use it to highlight unsafe refs | Paul Daniel Faria | 2020-08-10 | 1 | -0/+18 |
| |/ | | | | | | | | | | | Taking a reference to a misaligned field on a packed struct is an unsafe operation. Highlight that behavior. Currently, the misaligned part isn't tracked, so this highlight is a bit too aggressive. | ||||
* / | Minor | Aleksey Kladov | 2020-08-12 | 1 | -4/+3 |
|/ | |||||
* | Remove Option<...> from result of Crate::root_module | Paul Daniel Faria | 2020-08-09 | 1 | -2/+2 |
| | | | | | There doesn't seem to be any need for it, and removing it simplies several paths of code that depend on it. | ||||
* | Add support for extern crate | Paul Daniel Faria | 2020-08-08 | 1 | -3/+22 |
| | | | | | This adds syntax highlighting, hover and goto def functionality for extern crate | ||||
* | Use salsa's purge to account for all memory | Aleksey Kladov | 2020-08-05 | 1 | -8/+1 |
| | |||||
* | Rename BindPat -> IdentPat | Aleksey Kladov | 2020-07-31 | 4 | -6/+6 |
| | |||||
* | Allign RecordPat with RecordExpr | Aleksey Kladov | 2020-07-31 | 2 | -3/+3 |
| | |||||
* | simplify | Aleksey Kladov | 2020-07-30 | 1 | -6/+4 |
| | |||||
* | Finalize impl Grammar | Aleksey Kladov | 2020-07-30 | 3 | -6/+6 |
| | |||||
* | Finalize Trait grammar | Aleksey Kladov | 2020-07-30 | 3 | -7/+7 |
| | |||||
* | Finalize const&static grammar | Aleksey Kladov | 2020-07-30 | 3 | -12/+12 |
| | |||||
* | Rename EnumVariant -> Variant | Aleksey Kladov | 2020-07-30 | 3 | -5/+5 |
| | |||||
* | Rename EnumDef -> Enum | Aleksey Kladov | 2020-07-30 | 3 | -6/+6 |
| | |||||
* | Rename StructDef -> Struct | Aleksey Kladov | 2020-07-30 | 3 | -6/+6 |
| | |||||
* | Finalize union grammar | Aleksey Kladov | 2020-07-30 | 3 | -5/+5 |
| | |||||
* | Rename FieldDef -> Field | Aleksey Kladov | 2020-07-30 | 3 | -12/+6 |
| | |||||
* | Rename RecordLit -> RecordExpr | Aleksey Kladov | 2020-07-30 | 2 | -10/+13 |
| | |||||
* | Rename TypeAliasDef -> TypeAlias | Aleksey Kladov | 2020-07-30 | 3 | -9/+6 |
| | |||||
* | Rename FnDef -> Fn | Aleksey Kladov | 2020-07-30 | 3 | -7/+7 |
| | |||||
* | Add a builder for DiagnosticSink | Jonas Schievink | 2020-07-24 | 1 | -1/+3 |
| | |||||
* | Cache macro expansion in semantics | Aleksey Kladov | 2020-07-24 | 1 | -2/+14 |
| | | | | | #5497 accidentally made syntax highlighting quadratic, due to repeated tokentreeizing of macros. | ||||
* | Add missing cancellation point | Aleksey Kladov | 2020-07-24 | 1 | -0/+1 |
| | |||||
* | Add profiling call | Aleksey Kladov | 2020-07-24 | 1 | -0/+1 |
| | |||||
* | Store macro invocation parameters as text instead of tt | Laurențiu Nicola | 2020-07-22 | 1 | -1/+1 |
| | |||||
* | call_info works with closures | Aleksey Kladov | 2020-07-17 | 1 | -14/+19 |
| | |||||
* | Remove FunctionSignature | Aleksey Kladov | 2020-07-16 | 1 | -1/+1 |
| | |||||
* | Inlay hints use callables | Aleksey Kladov | 2020-07-16 | 1 | -0/+3 |
| | |||||
* | Redner self as param for call infor for assoc fn call | Aleksey Kladov | 2020-07-16 | 1 | -2/+12 |
| | |||||
* | Semantical call info | Aleksey Kladov | 2020-07-16 | 4 | -21/+99 |
| | |||||
* | Align CallableDefId naming with other ids | Aleksey Kladov | 2020-07-16 | 2 | -3/+3 |
| | |||||
* | Remove TypeCtor interning | Florian Diebold | 2020-07-15 | 1 | -3/+3 |
| | | | | Our TypeCtor and Chalk's TypeName match now! | ||||
* | Use Chalk closure support | Florian Diebold | 2020-07-15 | 1 | -3/+3 |
| | |||||
* | Cap macro expansion depth for IDE features | Aleksey Kladov | 2020-07-15 | 1 | -1/+1 |
| | | | | closes #4453 |