aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_syntax/src
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge #4851bors[bot]2020-06-191-0/+4
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | 4851: Add quickfix to add a struct field r=TimoFreiberg a=TimoFreiberg Related to #4563 I created a quickfix for record literals first because the NoSuchField diagnostic was already there. To offer that quickfix for FieldExprs with unknown fields I'd need to add a new diagnostic (or create a `NoSuchField` diagnostic for those cases) I think it'd make sense to make this a snippet completion (to select the generated type), but this would require changing the `Analysis` API and I'd like some feedback before I touch that. Co-authored-by: Timo Freiberg <[email protected]>
| * Add quickfix to add a struct fieldTimo Freiberg2020-06-121-0/+4
| |
* | Merge #4872bors[bot]2020-06-181-46/+43
|\ \ | | | | | | | | | | | | | | | | | | | | | 4872: Reduce the usage of bare subscript operator r=matklad a=Veetaha Co-authored-by: Veetaha <[email protected]>
| * | Reduce the usage of bare subscript operatorVeetaha2020-06-141-46/+43
| |/
* | Merge #4878bors[bot]2020-06-161-0/+8
|\ \ | | | | | | | | | | | | | | | | | | | | | 4878: Make "Replace qualified name with use" replace *all* mentions of the path r=matklad a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/4836 Co-authored-by: Jonas Schievink <[email protected]>
| * | Fix `rewrite_root` when there's only 1 replacementJonas Schievink2020-06-131-0/+8
| |/
* / Make ra_syntax::{SyntaxNodeChildren, SyntaxElementChildren} public.David Lattimore2020-06-151-1/+2
|/ | | | SyntaxNode::children and SyntaxNode::children_with_tokens return these types, but there's currently no way AFAIK to name them.
* Merge #4855bors[bot]2020-06-122-141/+141
|\ | | | | | | | | | | | | | | 4855: Use more idiomatic style for lifetimes in generated code r=matklad a=Veetaha Co-authored-by: Veetaha <[email protected]>
| * Apply codegen with idiomatic lifetimesVeetaha2020-06-112-141/+141
| |
* | SimplifyVeetaha2020-06-121-5/+5
|/
* Separating parsing of `for` in predicates and typesMatthew Jasper2020-06-102-1/+7
|
* Use correct indent when replacing with matchAleksey Kladov2020-06-091-4/+9
|
* Fix bug in lexer for format specifier where the `type` and `width` were not ↵Leander Tentrup2020-06-071-14/+23
| | | | correctly distinguished
* Enable hover and autocomplete docs on macro generated itemsAaron Loucks2020-06-031-2/+11
|
* Merge #4658bors[bot]2020-06-021-5/+0
|\ | | | | | | | | | | | | | | | | | | 4658: Fix problem with format string tokenization r=matklad a=ruabmbua Fixed by just not handling closing curlybrace escaping. Closes https://github.com/rust-analyzer/rust-analyzer/issues/4637 Co-authored-by: Roland Ruckerbauer <[email protected]>
| * Fix problem with format string tokenizationRoland Ruckerbauer2020-05-301-5/+0
| | | | | | | | Fixed by just not handling closing curlybrace escaping.
* | Simplifyveetaha2020-06-021-1/+1
| |
* | Small refactorveetaha2020-05-311-2/+2
| |
* | correctly infer labelled breaksrobojumper2020-05-311-0/+1
|/
* Support raw_ref_op's raw reference operatorrobojumper2020-05-281-0/+3
|
* Some FIXMEs were outdated:Julian Wollersberger2020-05-241-3/+1
| | | | | | | * Done at line 243: "Add validation of `crate` keyword not appearing in the middle of the symbol path" * Already happened: "Remove validation of unterminated literals (it is already implemented in `tokenize()`)" * Happens in `unescape()`: "Add validation of character literal containing only a single char" * Missing: "raw string literals and raw byte string literals"
* Update to rustc_lexer version 660.Julian Wollersberger2020-05-242-10/+11
| | | | Change `unescape_*()` to `unescape_literal()`.
*-. Merge #4521 #4522bors[bot]2020-05-203-35/+81
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4521: Use snippets in add_function r=matklad a=matklad bors r+ 🤖 4522: Explain the purpose of `ast::make` module more clearly r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Explain the purpose of `ast::make` module more clearlyAleksey Kladov2020-05-201-4/+7
| |/ |/|
| * Moderate cleanup of add_functionAleksey Kladov2020-05-203-31/+74
|/
* Shrink ra_parser::Event from 32 bytes to 16 bytesSimon Vandel Sillesen2020-05-161-1/+1
| | | | This boxes the Error variant with the assumption that it is rarely constructed
* Merge #4445bors[bot]2020-05-141-0/+4
|\ | | | | | | | | | | | | | | | | | | 4445: Correctly fill default type parameters r=flodiebold a=montekki Fixes #3877 So, basically even if the parameters are omitted from the `impl` block, check the parameters in `trait` if they have a default type, and if they do go from `hir` to `ast::TypeArg`. I've added a helper for that but I am not sure that it's a proper way to go from `hir` to `ast` here. Co-authored-by: Fedor Sakharov <[email protected]>
| * Change type_arg to type_ref funcFedor Sakharov2020-05-141-2/+2
| |
| * Correctly fill default type parametersFedor Sakharov2020-05-131-0/+4
| |
* | Use back ticks instead of single quotes around codeTrevor Spiteri2020-05-141-1/+1
|/
* Merge #4083bors[bot]2020-05-131-138/+1366
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4083: Smol documentation for ast nodes r=matklad a=Veetaha There is a tremendous amount of TODOs to clarify the topics I am not certain about. Please @matklad, @edwin0cheng review carefully, I even left some mentions of your names in todos to put your attention where you most probably can give comments. In order to simplify the review, I separated the codegen (i.e. changes in `ast/generated/nodes.rs`) from `ast_src` changes (they in fact just duplicate one another) into two commits. Also, I had to hack a little bit to let the docs be generated as doc comments and not as doc attributes because it's easier to read them this way and IIRC we don't support hints for `#[doc = ""]` attributes for now... Closes #3682 Co-authored-by: veetaha <[email protected]>
| * Remove an equals sign from `ConstArg` (this probably pertains only to ↵veetaha2020-05-121-1/+0
| | | | | | | | | | | | ConstParam) (As per matklad)
| * Convert TODO to a Note(matklad)veetaha2020-05-121-0/+1
| |
| * Convert to TODOs to FIXMEs as per matkladveetaha2020-05-121-4/+2
| |
| * Revert "Remove MacroStmts as per edwin0cheng" (cc @edwin0cheng) and add a ↵veetaha2020-05-121-0/+32
| | | | | | | | | | | | | | | | | | | | fixme to document it. This reverts commit 7a49165f5d5c8186edd04f874eae8a98e39d3df6. MacroStmts ast node is not used by itself, but it pertains to SyntaxNodeKind MACRO_STMTS that is used by ra_paser, so even tho the node itself is not used, it is better to keep it with a FIXME to actually add a doc comment when it becomes useful.
| * Add a doc comment on the difference between Name and NameRef ast nodesveetaha2020-05-121-1/+16
| |
| * Resolve TODO about macro 2.0 defveetaha2020-05-101-6/+4
| |
| * Fix typoveetaha2020-05-101-1/+1
| |
| * Carify on a semicolon in macro callveetaha2020-05-101-1/+6
| |
| * Resolve TODO about curly-braced constructions in expression statementveetaha2020-05-101-1/+3
| |
| * Resolve todos about refs and empty statementsveetaha2020-05-101-4/+4
| |
| * Converted TODO about MacroItems to FIXME as per edwin0chengveetaha2020-05-101-6/+2
| |
| * Verified ConstArg example, waiting for response on what `=` sign pertains toveetaha2020-05-101-1/+1
| |
| * Correcy use tree and type args docsveetaha2020-05-101-3/+3
| |
| * Correct `use` cannot have type args as per flodieboldveetaha2020-05-101-1/+1
| |
| * Correct path docs and add colon2 token to Path ast nodeveetaha2020-05-101-8/+14
| |
| * Add example with const in TypeBound as per flodieboldveetaha2020-05-101-1/+1
| |
| * Properly document const impl as per flodieboldveetaha2020-05-101-2/+2
| |
| * Remove MacroStmts as per edwin0chengveetaha2020-05-101-32/+0
| |
| * Add proper docs for TokenTree as per edwin0chengveetaha2020-05-101-1/+2
| |