aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* More useful fn detail in completionAleksey Kladov2021-01-229-93/+85
| | | | | | | | | | | | | Detail should be rendered as shtort one line, just dumping fn header there is not useful, despite the fact that TS does this. The fact that this is a function should be indicated by the icon, the same goes for pub/const/async etc qualitfiers name is already present in the lable (and arg list should be a part of that, as in idea) But the return type is the small genuinerlly useful bit of info we can show here
* Make assertion failures more annoying for maintainersAleksey Kladov2021-01-221-1/+6
|
*-. Merge #7310 #7395bors[bot]2021-01-2217-32/+292
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7310: Add assist: add lifetime to type r=matklad a=bnjjj close #7200 7395: Obtain `ModuleId`'s `DefMap` through a method r=jonas-schievink a=jonas-schievink Once `ModuleId` can represent modules inside block expressions, this will be required in order to obtain the correct `DefMap`. Otherwise existing code might use a `LocalModuleId` from the wrong `DefMap` and cause a panic. bors r+ Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Jonas Schievink <[email protected]>
| | * Obtain `ModuleId`'s `DefMap` through a methodJonas Schievink2021-01-2214-32/+43
| | |
| * | Add assist: add lifetime to type #7200Benjamin Coenen2021-01-212-18/+23
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | Add assist: add lifetime to type #7200Benjamin Coenen2021-01-181-0/+6
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | Add assist: add lifetime to type #7200Benjamin Coenen2021-01-173-0/+238
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | Merge #7353bors[bot]2021-01-2223-164/+225
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7353: Add LifetimeParam and ConstParam to CompletionItemKind r=matklad a=Veykril Adds `LifetimeParam` and `ConstParam` to `CompletionItemKind` and maps them both to `TypeParam` in the protocol conversion as there are no equivalents, so nothing really changes there. `ConstParam` could be mapped to `Const` I guess but I'm split on whether that would be better? Additions were solely inspired by (the single) test output for const params. Also sorts the variants of `CompletionItemKind` and its to_proto match. Co-authored-by: Lukas Wirth <[email protected]>
| * | Update completions test outputLukas Wirth2021-01-203-36/+66
| | |
| * | Partially unify SymbolKind and CompletionItemKindLukas Wirth2021-01-2013-108/+126
| | |
| * | Move SymbolKind to ide_dbLukas Wirth2021-01-2011-37/+40
| | |
| * | Add LifetimeParam and ConstParam to CompletionItemKindLukas Wirth2021-01-194-24/+34
| | |
* | | Merge #7386bors[bot]2021-01-222-1/+28
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7386: Handle box with allocator r=flodiebold a=tweksteen In 1.49.0, the definition of Box was modified to support an optional Allocator[1]. Adapt the parsing of the `box` keyword to supply the expected number of parameters to the constructor. [1] https://github.com/rust-lang/rust/commit/f288cd2e179f600fa00c2a407206a12f6c5a91e0 Fixes: #6956 Co-authored-by: Thiébaud Weksteen <[email protected]>
| * | | Handle box with allocatorThiébaud Weksteen2021-01-222-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 1.49.0, the definition of Box was modified to support an optional Allocator[1]. Adapt the parsing of the `box` keyword to supply the expected number of parameters to the constructor. [1] https://github.com/rust-lang/rust/commit/f288cd2e179f600fa00c2a407206a12f6c5a91e0
* | | | Merge #7348bors[bot]2021-01-224-3/+68
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7348: Fix broken link in intra-doc r=edwin0cheng a=sasurau4 Fix #5546 The intra-doc link doesn't work fine for trait associated method. Co-authored-by: Daiki Ihara <[email protected]>
| * | | | Fix broken link in intra-docDaiki Ihara2021-01-224-3/+68
| | | | |
* | | | | Merge #7389bors[bot]2021-01-221-60/+30
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7389: Remove approximate goto def r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Cleanup testsAleksey Kladov2021-01-221-12/+12
| | | | | |
| * | | | | Remove index based fallback for goto defAleksey Kladov2021-01-221-48/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are so precise that the fallback creates more confusion, when you can goto def on an unresolved reference.
* | | | | | Use AbsPathEdwin Cheng2021-01-221-3/+3
|/ / / / /
* | | | | Merge #7387bors[bot]2021-01-224-196/+228
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7387: Refactor build script specific data r=edwin0cheng a=edwin0cheng It refactors for separating logic for build script specific data. bors r+ Co-authored-by: Edwin Cheng <[email protected]>
| * | | | Refactor build script dataEdwin Cheng2021-01-224-196/+228
| | | | |
* | | | | Remove unused fieldJonas Schievink2021-01-211-4/+0
| | | | |
* | | | | Add test for path resolution bugJonas Schievink2021-01-211-8/+33
|/ / / /
* | | | Revert "Make use of `block_def_map` in body lowering"Jonas Schievink2021-01-213-19/+18
| | | |
* | | | Merge #7378bors[bot]2021-01-217-2/+30
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7378: Include `countme` crate to count important data structures. r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Include `countme` crate to count important data structures.Aleksey Kladov2021-01-217-2/+30
| | | | |
* | | | | Make use of `block_def_map` in body loweringJonas Schievink2021-01-213-18/+19
| | | | | | | | | | | | | | | | | | | | | | | | | Removes the `local_scope` hack from `Expander` in favor of tracking the `DefMap` in use during body lowering
* | | | | Remove unnecessary annotations from testsJonas Schievink2021-01-211-4/+0
|/ / / /
* | | | Add test for nameres in nested blocksJonas Schievink2021-01-211-0/+29
| | | |
* | | | Merge #7375bors[bot]2021-01-2110-58/+291
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7375: Add support for running name resolution in block expressions r=jonas-schievink a=jonas-schievink This adds a `block_def_map` query that runs the name resolution algorithm on a block expression, and returns a `DefMap` that stores links to the parent `DefMap` (either the containing block or the crate-level `DefMap`). Blocks with no inner items return the parent's `DefMap` as-is, to avoid creating unnecessarily long `DefMap` chains. Path resolution is updated to recurse into the parent `DefMap` after looking up a path in the original `DefMap`. I've added a few new tests for this, but outside of those this isn't used yet. bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Add test that merges inner and outer namesJonas Schievink2021-01-211-0/+25
| | | | |
| * | | | Fix lowering with multiple block expressionsJonas Schievink2021-01-211-15/+23
| | | | |
| * | | | Fall back to parent DefMaps when resolving pathsJonas Schievink2021-01-211-0/+37
| | | | |
| * | | | Add name resolution query for block expressionsJonas Schievink2021-01-218-43/+206
| | | | |
* | | | | Merge #7372bors[bot]2021-01-211-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7372: Up lexer r=kjeremy a=kjeremy No real changes here. Co-authored-by: kjeremy <[email protected]>
| * | | | | Up lexerkjeremy2021-01-211-1/+1
| |/ / / /
* | | | | Merge #7371bors[bot]2021-01-211-0/+17
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7371: Change directory before running rustfmt to respect rustfmt.toml r=matklad a=lnicola Fixes #6973 Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | chdir to file before rustfmtLaurențiu Nicola2021-01-211-0/+17
| | | | |
* | | | | Merge #7368bors[bot]2021-01-212-5/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7368: Clarify enabled features and defined features in PackageData r=matklad a=edwin0cheng Co-authored-by: Edwin Cheng <[email protected]>
| * | | | | Added defined_features in PackageDataEdwin Cheng2021-01-212-5/+8
| |/ / / /
* / / / / Bump chalkLaurențiu Nicola2021-01-211-3/+3
|/ / / /
* | | | Treat BlockExpr as a potential module originJonas Schievink2021-01-208-7/+44
| | | |
* | | | Merge #7365bors[bot]2021-01-201-3/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7365: chalk 0.49.0 r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | chalk 0.49.0kjeremy2021-01-201-3/+3
| | | | |
* | | | | DefMap: hide remaining crate-visible fieldsJonas Schievink2021-01-204-11/+23
|/ / / /
* | | | Merge #7359bors[bot]2021-01-203-32/+49
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7359: ItemTree: store a mapping from blocks to inner items r=jonas-schievink a=jonas-schievink To do name resolution within block expressions, we need to know which inner items are located inside each block expression. This adds such a mapping to `ItemTree`, replacing the previous one, which was seemingly unused other than to access all the inner items. This also assigns `AstId`s to block expressions, which is needed to store the mapping in salsa. Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Create a mapping from blocks to inner itemsJonas Schievink2021-01-202-26/+35
| | | | |
| * | | | Record `FileAstId`s for block expressiosnJonas Schievink2021-01-191-6/+14
| | | | | | | | | | | | | | | | | | | | | | | | | Every block expression may contain inner items, so we need to be able to refer to any block expression and use it as a salsa key.
* | | | | Make public DefMap fields privateJonas Schievink2021-01-2010-23/+31
| | | | |