From b6101184537b1165cfdd5fc473e04ad4c5b7bffa Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Mon, 2 Nov 2020 13:13:32 +0100 Subject: Deny unreachable-pub It's very useful when `pub` is equivalent to "this is crate's public API", let's enforce this! Ideally, we should enforce it for local `cargo test`, and only during CI, but that needs https://github.com/rust-lang/cargo/issues/5034. --- .github/workflows/ci.yaml | 2 +- .github/workflows/metrics.yaml | 2 +- .github/workflows/release.yaml | 2 +- .github/workflows/rustdoc.yaml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 77f2e2e16..83b1d33a1 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,7 +12,7 @@ env: CARGO_NET_RETRY: 10 CI: 1 RUST_BACKTRACE: short - RUSTFLAGS: -D warnings + RUSTFLAGS: "-D warnings " # -W unreachable-pub" RUSTUP_MAX_RETRIES: 10 jobs: diff --git a/.github/workflows/metrics.yaml b/.github/workflows/metrics.yaml index ea780e875..72050a527 100644 --- a/.github/workflows/metrics.yaml +++ b/.github/workflows/metrics.yaml @@ -7,7 +7,7 @@ on: env: CARGO_INCREMENTAL: 0 CARGO_NET_RETRY: 10 - RUSTFLAGS: -D warnings + RUSTFLAGS: "-D warnings " # -W unreachable-pub" RUSTUP_MAX_RETRIES: 10 jobs: diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index c1d56a8e0..fbefbd9eb 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -11,7 +11,7 @@ on: env: CARGO_INCREMENTAL: 0 CARGO_NET_RETRY: 10 - RUSTFLAGS: -D warnings + RUSTFLAGS: "-D warnings " # -W unreachable-pub" RUSTUP_MAX_RETRIES: 10 jobs: diff --git a/.github/workflows/rustdoc.yaml b/.github/workflows/rustdoc.yaml index cf4bca840..29ca3d3b2 100644 --- a/.github/workflows/rustdoc.yaml +++ b/.github/workflows/rustdoc.yaml @@ -7,7 +7,7 @@ on: env: CARGO_INCREMENTAL: 0 CARGO_NET_RETRY: 10 - RUSTFLAGS: -D warnings + RUSTFLAGS: "-D warnings " # -W unreachable-pub" RUSTUP_MAX_RETRIES: 10 jobs: -- cgit v1.2.3