From b446384956243ce6bdcef2a869123a2605e597ed Mon Sep 17 00:00:00 2001
From: Dmitry <mamhigtt@gmail.com>
Date: Mon, 17 Feb 2020 00:28:14 +0700
Subject: Added short description and disable-extensions

---
 .vscode/launch.json | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

(limited to '.vscode')

diff --git a/.vscode/launch.json b/.vscode/launch.json
index 55a2f10f2..386599f78 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -2,14 +2,21 @@
   // Use IntelliSense to learn about possible attributes.
   // Hover to view descriptions of existing attributes.
   // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+
+  // NOTE: --disable-extensions
+  // Disable all installed extensions for increas performance of playground 
+  // and prevent potential problem and collision with developer's extansion
+
   "version": "0.2.0",
   "configurations": [
     {
+      // Used for testing extansion that located in extensionDevelopmentPath
       "name": "Run Extension",
       "type": "extensionHost",
       "request": "launch",
       "runtimeExecutable": "${execPath}",
       "args": [
+        "--disable-extensions",
         "--extensionDevelopmentPath=${workspaceFolder}/editors/code"
       ],
       "outFiles": [
@@ -18,11 +25,13 @@
       "preLaunchTask": "Build Extension"
     },
     {
+      // Used for testing extansion with local lsp server located in __RA_LSP_SERVER_DEBUG
       "name": "Run Extension (Dev Server)",
       "type": "extensionHost",
       "request": "launch",
       "runtimeExecutable": "${execPath}",
       "args": [
+        "--disable-extensions",
         "--extensionDevelopmentPath=${workspaceFolder}/editors/code"
       ],
       "outFiles": [
@@ -34,7 +43,13 @@
       }
     },
     {
-      "name": "Debug Lsp Server",
+      // Attaching LLDB by Pid to lsp server
+      // NOTE: it requires root permission, also for better debugging
+      // if you want more than just assembler representation for ex: 
+      // walk in file, you need debugging symbols.
+      // Project can build with it, for set - chane inside
+      // ./Cargo.toml field debug 
+      "name": "Attach To Server",
       "type": "lldb",
       "request": "attach",
       "program": "${workspaceFolder}/target/debug/ra_lsp_server",
-- 
cgit v1.2.3


From 5b781de56c94db1f7035b2950eea1c387e6e53fa Mon Sep 17 00:00:00 2001
From: Aleksey Kladov <aleksey.kladov@gmail.com>
Date: Sun, 16 Feb 2020 18:54:32 +0100
Subject: Apply suggestions from code review
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
---
 .vscode/launch.json | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

(limited to '.vscode')

diff --git a/.vscode/launch.json b/.vscode/launch.json
index 386599f78..33fc3bdea 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -5,12 +5,13 @@
 
   // NOTE: --disable-extensions
   // Disable all installed extensions for increas performance of playground 
-  // and prevent potential problem and collision with developer's extansion
+  // Disable all installed extensions to increase performance of the debug instance 
+  // and prevent potential conflicts with other installed extensions.
 
   "version": "0.2.0",
   "configurations": [
     {
-      // Used for testing extansion that located in extensionDevelopmentPath
+      // Used for testing the extension with the installed LSP server.
       "name": "Run Extension",
       "type": "extensionHost",
       "request": "launch",
@@ -25,7 +26,7 @@
       "preLaunchTask": "Build Extension"
     },
     {
-      // Used for testing extansion with local lsp server located in __RA_LSP_SERVER_DEBUG
+      // Used for testing theextension with a local build of the LSP server (in `target/debug`).
       "name": "Run Extension (Dev Server)",
       "type": "extensionHost",
       "request": "launch",
-- 
cgit v1.2.3