From 0599e64bb296201b0aa5c637be34e28149d00e5d Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Fri, 2 Oct 2020 10:13:58 +0200 Subject: Document Clippy strategy --- docs/dev/style.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/dev/style.md b/docs/dev/style.md index f0fdb5adc..fb407afcd 100644 --- a/docs/dev/style.md +++ b/docs/dev/style.md @@ -371,3 +371,13 @@ After you are happy with the state of the code, please use [interactive rebase]( Avoid @mentioning people in commit messages and pull request descriptions(they are added to commit message by bors). Such messages create a lot of duplicate notification traffic during rebases. + +# Clippy + +We don't enforce Clippy. +A number of default lints have high false positive rate. +Selectively patching false-positives with `allow(clippy)` is considered worse than not using Clippy at all. +There's `cargo xtask lint` command which runs a subset of low-FPR lints. +Careful tweaking of `xtask lint` is welcome. +See also [rust-lang/clippy#5537](https://github.com/rust-lang/rust-clippy/issues/5537). +Of course, applying Clippy suggestions is welcome as long as they indeed improve the code. -- cgit v1.2.3