From 828f69ce549c9e07dec528247c97507749b1aec7 Mon Sep 17 00:00:00 2001 From: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com> Date: Fri, 17 Apr 2020 10:32:12 +0200 Subject: tests: add more info about what failed in tidy tests Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com> --- xtask/tests/tidy-tests/main.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xtask/tests/tidy-tests/main.rs b/xtask/tests/tidy-tests/main.rs index 101ae19bd..ead642acc 100644 --- a/xtask/tests/tidy-tests/main.rs +++ b/xtask/tests/tidy-tests/main.rs @@ -35,7 +35,7 @@ fn check_todo(path: &Path, text: &str) { } if text.contains("TODO") || text.contains("TOOD") || text.contains("todo!") { panic!( - "\nTODO markers should not be committed to the master branch,\n\ + "\nTODO markers or todo! macros should not be committed to the master branch,\n\ use FIXME instead\n\ {}\n", path.display(), @@ -47,9 +47,9 @@ fn check_trailing_ws(path: &Path, text: &str) { if is_exclude_dir(path, &["test_data"]) { return; } - for line in text.lines() { + for (line_number, line) in text.lines().enumerate() { if line.chars().last().map(char::is_whitespace) == Some(true) { - panic!("Trailing whitespace in {}", path.display()) + panic!("Trailing whitespace in {} at line {}", path.display(), line_number) } } } -- cgit v1.2.3