From 6bd1ff16e5e517c89a154b9b26847d20656e1184 Mon Sep 17 00:00:00 2001
From: Veetaha <gerzoh1@gmail.com>
Date: Sun, 8 Mar 2020 18:58:02 +0200
Subject: vscode: rename alwaysDownloadServer -> askBeforeDownload

The new name seems much simpler and it doesn't limit
this config value only to downloading the server binary.
Thus we wouldn't need to create another config
properties to handle other downloads whatsoever.
Anyway, I believe (heuristically) that most of the users
would want to set "askBeforeDownload": false once
and never bother clicking on the notification again
(because otherwise there is no big point in installing rust-analyzer if it cannot install the server)
---
 docs/user/readme.adoc      | 2 +-
 editors/code/package.json  | 6 +++---
 editors/code/src/config.ts | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/docs/user/readme.adoc b/docs/user/readme.adoc
index fb3312614..4ce05a26c 100644
--- a/docs/user/readme.adoc
+++ b/docs/user/readme.adoc
@@ -43,7 +43,7 @@ image::https://user-images.githubusercontent.com/9021944/75067008-17502500-54ba-
 > Note: to disable this notification put the following to `settings.json`
 > ```json
 {
-    "rust-analyzer.alwaysDownloadServer": true
+    "rust-analyzer.askBeforeDownload": false
 }
 ```
 
diff --git a/editors/code/package.json b/editors/code/package.json
index 7bcd45e15..430a61c64 100644
--- a/editors/code/package.json
+++ b/editors/code/package.json
@@ -219,10 +219,10 @@
                         }
                     }
                 },
-                "rust-analyzer.alwaysDownloadServer": {
+                "rust-analyzer.askBeforeDownload": {
                     "type": "boolean",
-                    "default": false,
-                    "description": "Whether to ask before downloading the language server binary"
+                    "default": true,
+                    "description": "Whether to ask for permission before downloading any files from the Internet"
                 },
                 "rust-analyzer.serverPath": {
                     "type": [
diff --git a/editors/code/src/config.ts b/editors/code/src/config.ts
index c4acb632d..cb9af86c0 100644
--- a/editors/code/src/config.ts
+++ b/editors/code/src/config.ts
@@ -134,7 +134,7 @@ export class Config {
             file: prebuiltBinaryName,
             storage: this.ctx.globalState,
             tag: Config.extensionVersion,
-            askBeforeDownload: !(this.cfg.get("alwaysDownloadServer") as boolean),
+            askBeforeDownload: !(this.cfg.get("askBeforeDownload") as boolean),
             repo: {
                 name: "rust-analyzer",
                 owner: "rust-analyzer",
-- 
cgit v1.2.3