From 04741ae2bc70bc002f62b9b142057dd6eabcec75 Mon Sep 17 00:00:00 2001 From: Shotaro Yamada Date: Fri, 11 Oct 2019 06:50:53 +0900 Subject: Use `original_file` instead of `as_original_file` --- crates/ra_ide_api/src/display/navigation_target.rs | 6 +++--- crates/ra_ide_api/src/references.rs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/ra_ide_api/src/display/navigation_target.rs b/crates/ra_ide_api/src/display/navigation_target.rs index d0b1a8a2a..5cb67fb95 100644 --- a/crates/ra_ide_api/src/display/navigation_target.rs +++ b/crates/ra_ide_api/src/display/navigation_target.rs @@ -119,7 +119,7 @@ impl NavigationTarget { pub(crate) fn from_module(db: &RootDatabase, module: hir::Module) -> NavigationTarget { let src = module.definition_source(db); - let file_id = src.file_id.as_original_file(); + let file_id = src.file_id.original_file(db); let name = module.name(db).map(|it| it.to_string().into()).unwrap_or_default(); match src.ast { ModuleSource::SourceFile(node) => { @@ -139,7 +139,7 @@ impl NavigationTarget { pub(crate) fn from_module_to_decl(db: &RootDatabase, module: hir::Module) -> NavigationTarget { let name = module.name(db).map(|it| it.to_string().into()).unwrap_or_default(); if let Some(src) = module.declaration_source(db) { - let file_id = src.file_id.as_original_file(); + let file_id = src.file_id.original_file(db); return NavigationTarget::from_syntax( file_id, name, @@ -213,7 +213,7 @@ impl NavigationTarget { ) -> NavigationTarget { let src = impl_block.source(db); NavigationTarget::from_syntax( - src.file_id.as_original_file(), + src.file_id.original_file(db), "impl".into(), None, src.ast.syntax(), diff --git a/crates/ra_ide_api/src/references.rs b/crates/ra_ide_api/src/references.rs index 84c2eb793..c95c47bf1 100644 --- a/crates/ra_ide_api/src/references.rs +++ b/crates/ra_ide_api/src/references.rs @@ -140,7 +140,7 @@ fn rename_mod( let module_src = hir::Source { file_id: position.file_id.into(), ast: ast_module.clone() }; if let Some(module) = hir::Module::from_declaration(db, module_src) { let src = module.definition_source(db); - let file_id = src.file_id.as_original_file(); + let file_id = src.file_id.original_file(db); match src.ast { ModuleSource::SourceFile(..) => { let mod_path: RelativePathBuf = db.file_relative_path(file_id); -- cgit v1.2.3 From 0d0a444d4380d9d1eb580d862b2376b9693d77f3 Mon Sep 17 00:00:00 2001 From: Shotaro Yamada Date: Fri, 11 Oct 2019 06:53:31 +0900 Subject: Remove `as_original_file` --- crates/ra_hir/src/ids.rs | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/crates/ra_hir/src/ids.rs b/crates/ra_hir/src/ids.rs index a3b65cc79..85b022744 100644 --- a/crates/ra_hir/src/ids.rs +++ b/crates/ra_hir/src/ids.rs @@ -50,16 +50,6 @@ impl HirFileId { } } - /// XXX: this is a temporary function, which should go away when we implement the - /// nameresolution+macro expansion combo. Prefer using `original_file` if - /// possible. - pub fn as_original_file(self) -> FileId { - match self.0 { - HirFileIdRepr::File(file_id) => file_id, - HirFileIdRepr::Macro(_r) => panic!("macro generated file: {:?}", self), - } - } - /// Get the crate which the macro lives in, if it is a macro file. pub(crate) fn macro_crate(self, db: &impl AstDatabase) -> Option { match self.0 { -- cgit v1.2.3