From 13b8449a11e51a9381f8e39b629be04a3f35dba0 Mon Sep 17 00:00:00 2001 From: Jonas Schievink Date: Tue, 25 May 2021 00:56:19 +0200 Subject: Update `CrateGraph` comment `cfg` flags are now implemented, and crates *may* have names, it doesn't doesn't matter for name resolution --- crates/base_db/src/input.rs | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) (limited to 'crates/base_db/src') diff --git a/crates/base_db/src/input.rs b/crates/base_db/src/input.rs index 0ef77ef5d..64ccd11ee 100644 --- a/crates/base_db/src/input.rs +++ b/crates/base_db/src/input.rs @@ -53,11 +53,15 @@ impl SourceRoot { } /// `CrateGraph` is a bit of information which turns a set of text files into a -/// number of Rust crates. Each crate is defined by the `FileId` of its root module, -/// the set of cfg flags (not yet implemented) and the set of dependencies. Note -/// that, due to cfg's, there might be several crates for a single `FileId`! As -/// in the rust-lang proper, a crate does not have a name. Instead, names are -/// specified on dependency edges. That is, a crate might be known under +/// number of Rust crates. +/// +/// Each crate is defined by the `FileId` of its root module, the set of enabled +/// `cfg` flags and the set of dependencies. +/// +/// Note that, due to cfg's, there might be several crates for a single `FileId`! +/// +/// For the purposes of analysis, a crate does not have a name. Instead, names +/// are specified on dependency edges. That is, a crate might be known under /// different names in different dependent crates. /// /// Note that `CrateGraph` is build-system agnostic: it's a concept of the Rust -- cgit v1.2.3