From 6e87828756d970e9c25635aa9f71f0a90cc8ff65 Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Wed, 6 Jan 2021 20:23:53 +0300 Subject: YAGNI active_resolve_capabilities This leaks a lot of LSP details into ide layer, which we want to avoid: https://github.com/rust-analyzer/rust-analyzer/tree/c9cec381bcfd97e5f3536e31a9c546ab5c0665e6/docs/dev#lsp-independence Additionally, all what this infra does is providing a toggle for auto-import completion, but we already have one! --- crates/completion/src/completions/unqualified_path.rs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'crates/completion/src/completions') diff --git a/crates/completion/src/completions/unqualified_path.rs b/crates/completion/src/completions/unqualified_path.rs index 2f41a3f96..896f167ff 100644 --- a/crates/completion/src/completions/unqualified_path.rs +++ b/crates/completion/src/completions/unqualified_path.rs @@ -46,7 +46,7 @@ pub(crate) fn complete_unqualified_path(acc: &mut Completions, ctx: &CompletionC acc.add_resolution(ctx, name.to_string(), &res) }); - if ctx.config.enable_autoimport_completions && ctx.config.resolve_additional_edits_lazily() { + if ctx.config.enable_autoimport_completions { fuzzy_completion(acc, ctx); } } @@ -206,11 +206,7 @@ mod tests { } fn fuzzy_completion_config() -> CompletionConfig { - let mut completion_config = CompletionConfig::default(); - completion_config - .active_resolve_capabilities - .insert(crate::CompletionResolveCapability::AdditionalTextEdits); - completion_config + CompletionConfig::default() } #[test] -- cgit v1.2.3