From 7b92a55ff700019908c137493435c12d50a2d8e0 Mon Sep 17 00:00:00 2001 From: Gowri Date: Mon, 8 Feb 2021 09:57:16 +1030 Subject: fix: add for keyword in completion #7588 --- crates/completion/src/completions/keyword.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'crates/completion') diff --git a/crates/completion/src/completions/keyword.rs b/crates/completion/src/completions/keyword.rs index 47e146128..17a8069fe 100644 --- a/crates/completion/src/completions/keyword.rs +++ b/crates/completion/src/completions/keyword.rs @@ -88,6 +88,7 @@ pub(crate) fn complete_expr_keyword(acc: &mut Completions, ctx: &CompletionConte add_keyword(ctx, acc, "loop", "loop {$0}"); add_keyword(ctx, acc, "if", "if $0 {}"); add_keyword(ctx, acc, "if let", "if let $1 = $0 {}"); + add_keyword(ctx, acc, "for", "for $0 in $1 {}"); } if ctx.if_is_prev || ctx.block_expr_parent { -- cgit v1.2.3 From 498dfc45d44786ccd83b2b0d963dc23020ce4f1a Mon Sep 17 00:00:00 2001 From: Gowri Date: Mon, 8 Feb 2021 10:16:20 +1030 Subject: ci: update relevant test case expected values --- crates/completion/src/completions/keyword.rs | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'crates/completion') diff --git a/crates/completion/src/completions/keyword.rs b/crates/completion/src/completions/keyword.rs index 17a8069fe..123b944d9 100644 --- a/crates/completion/src/completions/keyword.rs +++ b/crates/completion/src/completions/keyword.rs @@ -259,6 +259,7 @@ mod tests { kw loop kw if kw if let + kw for kw let kw mod kw const @@ -285,6 +286,7 @@ mod tests { kw loop kw if kw if let + kw for kw let kw mod kw const @@ -311,6 +313,7 @@ mod tests { kw loop kw if kw if let + kw for kw let kw else kw else if @@ -344,6 +347,7 @@ fn quux() -> i32 { kw loop kw if kw if let + kw for kw unsafe kw return "#]], @@ -392,6 +396,7 @@ fn quux() -> i32 { kw loop kw if kw if let + kw for kw let kw mod kw const @@ -550,6 +555,7 @@ pub mod future { kw loop kw if kw if let + kw for kw return "#]], ) @@ -608,6 +614,7 @@ fn foo() { kw loop kw if kw if let + kw for kw return "#]], ); -- cgit v1.2.3 From 6b947567e196fe29f4c4934295a60d791d97c069 Mon Sep 17 00:00:00 2001 From: Gowri Date: Mon, 8 Feb 2021 18:22:46 +1030 Subject: chore: swap order of placeholders --- crates/completion/src/completions/keyword.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'crates/completion') diff --git a/crates/completion/src/completions/keyword.rs b/crates/completion/src/completions/keyword.rs index 123b944d9..eb81f9765 100644 --- a/crates/completion/src/completions/keyword.rs +++ b/crates/completion/src/completions/keyword.rs @@ -88,7 +88,7 @@ pub(crate) fn complete_expr_keyword(acc: &mut Completions, ctx: &CompletionConte add_keyword(ctx, acc, "loop", "loop {$0}"); add_keyword(ctx, acc, "if", "if $0 {}"); add_keyword(ctx, acc, "if let", "if let $1 = $0 {}"); - add_keyword(ctx, acc, "for", "for $0 in $1 {}"); + add_keyword(ctx, acc, "for", "for $1 in $0 {}"); } if ctx.if_is_prev || ctx.block_expr_parent { -- cgit v1.2.3