From cf494a515ff70675a4531585aa24a792f5b5e896 Mon Sep 17 00:00:00 2001 From: Jonas Schievink Date: Fri, 19 Mar 2021 18:24:04 +0100 Subject: Fix handling of `#![cfg]` in outline module file --- crates/hir_def/src/nameres/collector.rs | 50 +++++++++++++++++++-------------- 1 file changed, 29 insertions(+), 21 deletions(-) (limited to 'crates/hir_def/src/nameres/collector.rs') diff --git a/crates/hir_def/src/nameres/collector.rs b/crates/hir_def/src/nameres/collector.rs index 4bcdc0fc8..46a3c60cd 100644 --- a/crates/hir_def/src/nameres/collector.rs +++ b/crates/hir_def/src/nameres/collector.rs @@ -1294,29 +1294,37 @@ impl ModCollector<'_, '_> { let db = self.def_collector.db; match self.mod_dir.resolve_declaration(db, self.file_id, &module.name, path_attr) { Ok((file_id, is_mod_rs, mod_dir)) => { - let module_id = self.push_child_module( - module.name.clone(), - ast_id, - Some((file_id, is_mod_rs)), - &self.item_tree[module.visibility], - ); let item_tree = db.file_item_tree(file_id.into()); - ModCollector { - def_collector: &mut *self.def_collector, - macro_depth: self.macro_depth, - module_id, - file_id: file_id.into(), - item_tree: &item_tree, - mod_dir, - } - .collect(item_tree.top_level_items()); - if is_macro_use - || item_tree - .top_level_attrs(db, self.def_collector.def_map.krate) - .by_key("macro_use") - .exists() + if item_tree + .top_level_attrs(db, self.def_collector.def_map.krate) + .cfg() + .map_or(true, |cfg| { + self.def_collector.cfg_options.check(&cfg) != Some(false) + }) { - self.import_all_legacy_macros(module_id); + let module_id = self.push_child_module( + module.name.clone(), + ast_id, + Some((file_id, is_mod_rs)), + &self.item_tree[module.visibility], + ); + ModCollector { + def_collector: &mut *self.def_collector, + macro_depth: self.macro_depth, + module_id, + file_id: file_id.into(), + item_tree: &item_tree, + mod_dir, + } + .collect(item_tree.top_level_items()); + if is_macro_use + || item_tree + .top_level_attrs(db, self.def_collector.def_map.krate) + .by_key("macro_use") + .exists() + { + self.import_all_legacy_macros(module_id); + } } } Err(candidate) => { -- cgit v1.2.3