From 048dad8c2e86006e53b3a134279729efb28b9e32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20Kr=C3=BCger?= Date: Wed, 17 Mar 2021 01:56:31 +0100 Subject: don't clone types that are copy (clippy::clone_on_copy) --- crates/ide/src/doc_links.rs | 4 ++-- crates/ide/src/goto_definition.rs | 2 +- crates/ide/src/syntax_highlighting/inject.rs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'crates/ide/src') diff --git a/crates/ide/src/doc_links.rs b/crates/ide/src/doc_links.rs index 461e11060..5ea9fc4fb 100644 --- a/crates/ide/src/doc_links.rs +++ b/crates/ide/src/doc_links.rs @@ -93,7 +93,7 @@ pub(crate) fn remove_links(markdown: &str) -> String { let mut cb = |_: BrokenLink| { let empty = InlineStr::try_from("").unwrap(); - Some((CowStr::Inlined(empty.clone()), CowStr::Inlined(empty))) + Some((CowStr::Inlined(empty), CowStr::Inlined(empty))) }; let doc = Parser::new_with_broken_link_callback(markdown, opts, Some(&mut cb)); let doc = doc.filter_map(move |evt| match evt { @@ -147,7 +147,7 @@ fn get_doc_link(db: &RootDatabase, definition: Definition) -> Option { _ => return None, }; - let ns = ItemInNs::from(target_def.clone()); + let ns = ItemInNs::from(target_def); let module = definition.module(db)?; let krate = module.krate(); diff --git a/crates/ide/src/goto_definition.rs b/crates/ide/src/goto_definition.rs index 6986477a5..b71f4917c 100644 --- a/crates/ide/src/goto_definition.rs +++ b/crates/ide/src/goto_definition.rs @@ -102,7 +102,7 @@ fn extract_positioned_link_from_comment( None => comment_range.end(), } })?; - Some((def_link.to_string(), ns.clone())) + Some((def_link.to_string(), *ns)) } fn pick_best(tokens: TokenAtOffset) -> Option { diff --git a/crates/ide/src/syntax_highlighting/inject.rs b/crates/ide/src/syntax_highlighting/inject.rs index 8cdc3688f..4f825523c 100644 --- a/crates/ide/src/syntax_highlighting/inject.rs +++ b/crates/ide/src/syntax_highlighting/inject.rs @@ -56,7 +56,7 @@ pub(super) fn ra_fixture( for range in inj.map_range_up(hl_range.range) { if let Some(range) = literal.map_range_up(range) { hl_range.range = range; - hl.add(hl_range.clone()); + hl.add(hl_range); } } } -- cgit v1.2.3