From a14194b428efdb09cc45f9862ec34bef0038cd35 Mon Sep 17 00:00:00 2001
From: Zac Pullar-Strecker <zacmps@gmail.com>
Date: Tue, 1 Sep 2020 11:38:32 +1200
Subject: Changes from review

---
 crates/ide/src/doc_links.rs | 3 ---
 crates/ide/src/lib.rs       | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

(limited to 'crates/ide')

diff --git a/crates/ide/src/doc_links.rs b/crates/ide/src/doc_links.rs
index 1e102997f..7fe88577d 100644
--- a/crates/ide/src/doc_links.rs
+++ b/crates/ide/src/doc_links.rs
@@ -100,9 +100,6 @@ pub fn get_doc_link<T: Resolvable + Clone>(db: &dyn HirDatabase, definition: &T)
 // BUG: For Option
 // Returns https://doc.rust-lang.org/nightly/core/prelude/v1/enum.Option.html#variant.Some
 // Instead of https://doc.rust-lang.org/nightly/core/option/enum.Option.html
-//
-// BUG: For methods
-// import_map.path_of(ns) fails, is not designed to resolve methods
 fn get_doc_link_impl(db: &dyn HirDatabase, moddef: &ModuleDef) -> Option<String> {
     // Get the outermost definition for the moduledef. This is used to resolve the public path to the type,
     // then we can join the method, field, etc onto it if required.
diff --git a/crates/ide/src/lib.rs b/crates/ide/src/lib.rs
index b92e6d9ea..0580d2979 100644
--- a/crates/ide/src/lib.rs
+++ b/crates/ide/src/lib.rs
@@ -383,7 +383,7 @@ impl Analysis {
     }
 
     /// Return URL(s) for the documentation of the symbol under the cursor.
-    pub fn get_doc_url(
+    pub fn external_docs(
         &self,
         position: FilePosition,
     ) -> Cancelable<Option<doc_links::DocumentationLink>> {
-- 
cgit v1.2.3