From e31a762c63d0fd61e4b84b27b6ebf142c4437487 Mon Sep 17 00:00:00 2001 From: Eduardo Canellas Date: Tue, 25 May 2021 11:42:16 -0300 Subject: fix: don't show pd/ppd completions where it shouldn't be --- crates/ide_completion/src/completions/record.rs | 10 +--------- crates/ide_completion/src/completions/snippet.rs | 6 ++++-- 2 files changed, 5 insertions(+), 11 deletions(-) (limited to 'crates/ide_completion/src/completions') diff --git a/crates/ide_completion/src/completions/record.rs b/crates/ide_completion/src/completions/record.rs index 2f95b8687..40006fb74 100644 --- a/crates/ide_completion/src/completions/record.rs +++ b/crates/ide_completion/src/completions/record.rs @@ -108,8 +108,6 @@ fn process(f: S) { check_snippet( test_code, expect![[r#" - sn pd - sn ppd fd ..Default::default() "#]], ); @@ -179,13 +177,7 @@ fn process(f: S) { "#]], ); - check_snippet( - test_code, - expect![[r#" - sn pd - sn ppd - "#]], - ); + check_snippet(test_code, expect![[r#""#]]); } #[test] diff --git a/crates/ide_completion/src/completions/snippet.rs b/crates/ide_completion/src/completions/snippet.rs index 7f7830976..14cfb61de 100644 --- a/crates/ide_completion/src/completions/snippet.rs +++ b/crates/ide_completion/src/completions/snippet.rs @@ -22,8 +22,10 @@ pub(crate) fn complete_expr_snippet(acc: &mut Completions, ctx: &CompletionConte None => return, }; - snippet(ctx, cap, "pd", "eprintln!(\"$0 = {:?}\", $0);").add_to(acc); - snippet(ctx, cap, "ppd", "eprintln!(\"$0 = {:#?}\", $0);").add_to(acc); + if ctx.can_be_stmt { + snippet(ctx, cap, "pd", "eprintln!(\"$0 = {:?}\", $0);").add_to(acc); + snippet(ctx, cap, "ppd", "eprintln!(\"$0 = {:#?}\", $0);").add_to(acc); + } } pub(crate) fn complete_item_snippet(acc: &mut Completions, ctx: &CompletionContext) { -- cgit v1.2.3