From f840fcb2f525c13809d6a736e434155edf075a06 Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Thu, 19 Mar 2020 16:00:11 +0100 Subject: Simplify Arena to use a generic index --- crates/ra_arena/src/map.rs | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) (limited to 'crates/ra_arena/src/map.rs') diff --git a/crates/ra_arena/src/map.rs b/crates/ra_arena/src/map.rs index b73d4e365..5e764113d 100644 --- a/crates/ra_arena/src/map.rs +++ b/crates/ra_arena/src/map.rs @@ -2,17 +2,17 @@ use std::marker::PhantomData; -use super::ArenaId; +use crate::Idx; /// A map from arena IDs to some other type. Space requirement is O(highest ID). #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)] -pub struct ArenaMap { - v: Vec>, +pub struct ArenaMap { + v: Vec>, _ty: PhantomData, } -impl ArenaMap { - pub fn insert(&mut self, id: ID, t: T) { +impl ArenaMap, V> { + pub fn insert(&mut self, id: Idx, t: V) { let idx = Self::to_idx(id); if self.v.capacity() <= idx { self.v.reserve(idx + 1 - self.v.capacity()); @@ -25,43 +25,43 @@ impl ArenaMap { self.v[idx] = Some(t); } - pub fn get(&self, id: ID) -> Option<&T> { + pub fn get(&self, id: Idx) -> Option<&V> { self.v.get(Self::to_idx(id)).and_then(|it| it.as_ref()) } - pub fn get_mut(&mut self, id: ID) -> Option<&mut T> { + pub fn get_mut(&mut self, id: Idx) -> Option<&mut V> { self.v.get_mut(Self::to_idx(id)).and_then(|it| it.as_mut()) } - pub fn values(&self) -> impl Iterator { + pub fn values(&self) -> impl Iterator { self.v.iter().filter_map(|o| o.as_ref()) } - pub fn values_mut(&mut self) -> impl Iterator { + pub fn values_mut(&mut self) -> impl Iterator { self.v.iter_mut().filter_map(|o| o.as_mut()) } - pub fn iter(&self) -> impl Iterator { + pub fn iter(&self) -> impl Iterator, &V)> { self.v.iter().enumerate().filter_map(|(idx, o)| Some((Self::from_idx(idx), o.as_ref()?))) } - fn to_idx(id: ID) -> usize { + fn to_idx(id: Idx) -> usize { u32::from(id.into_raw()) as usize } - fn from_idx(idx: usize) -> ID { - ID::from_raw((idx as u32).into()) + fn from_idx(idx: usize) -> Idx { + Idx::from_raw((idx as u32).into()) } } -impl std::ops::Index for ArenaMap { +impl std::ops::Index> for ArenaMap, T> { type Output = T; - fn index(&self, id: ID) -> &T { + fn index(&self, id: Idx) -> &T { self.v[Self::to_idx(id)].as_ref().unwrap() } } -impl Default for ArenaMap { +impl Default for ArenaMap, T> { fn default() -> Self { ArenaMap { v: Vec::new(), _ty: PhantomData } } -- cgit v1.2.3