From 4fc233a02e8dc07619a969400c445ec47c2b1a9d Mon Sep 17 00:00:00 2001 From: Marcus Klaas de Vries Date: Sat, 5 Jan 2019 21:28:30 +0100 Subject: Implement type inference for boolean operators --- crates/ra_hir/src/ty.rs | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) (limited to 'crates/ra_hir/src/ty.rs') diff --git a/crates/ra_hir/src/ty.rs b/crates/ra_hir/src/ty.rs index e33762e0d..718e193f7 100644 --- a/crates/ra_hir/src/ty.rs +++ b/crates/ra_hir/src/ty.rs @@ -26,7 +26,7 @@ use ena::unify::{InPlaceUnificationTable, UnifyKey, UnifyValue, NoError}; use ra_db::{LocalSyntaxPtr, Cancelable}; use ra_syntax::{ - ast::{self, AstNode, LoopBodyOwner, ArgListOwner, PrefixOp}, + ast::{self, AstNode, LoopBodyOwner, ArgListOwner, PrefixOp, BinOp}, SyntaxNodeRef }; @@ -906,7 +906,16 @@ impl<'a, D: HirDatabase> InferenceContext<'a, D> { } } ast::Expr::RangeExpr(_e) => Ty::Unknown, - ast::Expr::BinExpr(_e) => Ty::Unknown, + ast::Expr::BinExpr(e) => match e.op() { + Some(BinOp::BooleanOr) + | Some(BinOp::BooleanAnd) + | Some(BinOp::EqualityTest) + | Some(BinOp::LesserEqualTest) + | Some(BinOp::GreaterEqualTest) + | Some(BinOp::LesserTest) + | Some(BinOp::GreaterTest) => Ty::Bool, + _ => Ty::Unknown, + }, ast::Expr::Literal(_e) => Ty::Unknown, }; // use a new type variable if we got Ty::Unknown here -- cgit v1.2.3