From e8815b614e4a02f9270245f2d5c557999b58239d Mon Sep 17 00:00:00 2001
From: Aleksey Kladov <aleksey.kladov@gmail.com>
Date: Wed, 9 Jan 2019 19:14:21 +0300
Subject: nicer trailing comma handling in types

---
 crates/ra_hir/src/ty.rs | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

(limited to 'crates/ra_hir/src/ty.rs')

diff --git a/crates/ra_hir/src/ty.rs b/crates/ra_hir/src/ty.rs
index 3b2bfd67a..eb7764f65 100644
--- a/crates/ra_hir/src/ty.rs
+++ b/crates/ra_hir/src/ty.rs
@@ -25,6 +25,7 @@ use std::{fmt, mem};
 use log;
 use ena::unify::{InPlaceUnificationTable, UnifyKey, UnifyValue, NoError};
 use ra_arena::map::ArenaMap;
+use join_to_string::join;
 
 use ra_db::Cancelable;
 
@@ -396,18 +397,21 @@ impl fmt::Display for Ty {
             Ty::Ref(t, m) => write!(f, "&{}{}", m.as_keyword_for_ref(), t),
             Ty::Never => write!(f, "!"),
             Ty::Tuple(ts) => {
-                write!(f, "(")?;
-                for t in ts.iter() {
-                    write!(f, "{},", t)?;
+                if ts.len() == 1 {
+                    write!(f, "({},)", ts[0])
+                } else {
+                    join(ts.iter())
+                        .surround_with("(", ")")
+                        .separator(", ")
+                        .to_fmt(f)
                 }
-                write!(f, ")")
             }
             Ty::FnPtr(sig) => {
-                write!(f, "fn(")?;
-                for t in &sig.input {
-                    write!(f, "{},", t)?;
-                }
-                write!(f, ") -> {}", sig.output)
+                join(sig.input.iter())
+                    .surround_with("fn(", ")")
+                    .separator(", ")
+                    .to_fmt(f)?;
+                write!(f, " -> {}", sig.output)
             }
             Ty::Adt { name, .. } => write!(f, "{}", name),
             Ty::Unknown => write!(f, "[unknown]"),
-- 
cgit v1.2.3