From 001e34e6e31503195d176a349bc9476681c79e7f Mon Sep 17 00:00:00 2001
From: Jeremy Kolb <kjeremy@gmail.com>
Date: Fri, 5 Jul 2019 12:02:32 -0400
Subject: Clippy trivially_copy_pass_by_ref

---
 crates/ra_hir/src/ty/infer.rs             |  4 ++--
 crates/ra_hir/src/ty/method_resolution.rs | 10 +++++-----
 crates/ra_hir/src/ty/primitive.rs         |  2 +-
 crates/ra_hir/src/ty/traits.rs            |  2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

(limited to 'crates/ra_hir/src/ty')

diff --git a/crates/ra_hir/src/ty/infer.rs b/crates/ra_hir/src/ty/infer.rs
index 8322de0a8..a23daabc2 100644
--- a/crates/ra_hir/src/ty/infer.rs
+++ b/crates/ra_hir/src/ty/infer.rs
@@ -85,7 +85,7 @@ enum BindingMode {
 }
 
 impl BindingMode {
-    pub fn convert(annotation: &BindingAnnotation) -> BindingMode {
+    pub fn convert(annotation: BindingAnnotation) -> BindingMode {
         match annotation {
             BindingAnnotation::Unannotated | BindingAnnotation::Mutable => BindingMode::Move,
             BindingAnnotation::Ref => BindingMode::Ref(Mutability::Shared),
@@ -778,7 +778,7 @@ impl<'a, D: HirDatabase> InferenceContext<'a, D> {
                 let mode = if mode == &BindingAnnotation::Unannotated {
                     default_bm
                 } else {
-                    BindingMode::convert(mode)
+                    BindingMode::convert(*mode)
                 };
                 let inner_ty = if let Some(subpat) = subpat {
                     self.infer_pat(*subpat, expected, default_bm)
diff --git a/crates/ra_hir/src/ty/method_resolution.rs b/crates/ra_hir/src/ty/method_resolution.rs
index bc890fe79..10a6e0b10 100644
--- a/crates/ra_hir/src/ty/method_resolution.rs
+++ b/crates/ra_hir/src/ty/method_resolution.rs
@@ -58,7 +58,7 @@ impl CrateImplBlocks {
 
     pub fn lookup_impl_blocks_for_trait<'a>(
         &'a self,
-        tr: &Trait,
+        tr: Trait,
     ) -> impl Iterator<Item = ImplBlock> + 'a {
         self.impls_by_trait.get(&tr).into_iter().flat_map(|i| i.iter()).map(
             move |(module_id, impl_id)| {
@@ -68,8 +68,8 @@ impl CrateImplBlocks {
         )
     }
 
-    fn collect_recursive(&mut self, db: &impl HirDatabase, module: &Module) {
-        let module_impl_blocks = db.impls_in_module(module.clone());
+    fn collect_recursive(&mut self, db: &impl HirDatabase, module: Module) {
+        let module_impl_blocks = db.impls_in_module(module);
 
         for (impl_id, _) in module_impl_blocks.impls.iter() {
             let impl_block = ImplBlock::from_id(module_impl_blocks.module, impl_id);
@@ -94,7 +94,7 @@ impl CrateImplBlocks {
         }
 
         for child in module.children(db) {
-            self.collect_recursive(db, &child);
+            self.collect_recursive(db, child);
         }
     }
 
@@ -108,7 +108,7 @@ impl CrateImplBlocks {
             impls_by_trait: FxHashMap::default(),
         };
         if let Some(module) = krate.root_module(db) {
-            crate_impl_blocks.collect_recursive(db, &module);
+            crate_impl_blocks.collect_recursive(db, module);
         }
         Arc::new(crate_impl_blocks)
     }
diff --git a/crates/ra_hir/src/ty/primitive.rs b/crates/ra_hir/src/ty/primitive.rs
index 62b75b764..2c60fefd6 100644
--- a/crates/ra_hir/src/ty/primitive.rs
+++ b/crates/ra_hir/src/ty/primitive.rs
@@ -131,7 +131,7 @@ impl IntTy {
         IntTy { signedness: Signedness::Unsigned, bitness: IntBitness::X128 }
     }
 
-    pub(crate) fn ty_to_string(&self) -> &'static str {
+    pub(crate) fn ty_to_string(self) -> &'static str {
         match (self.signedness, self.bitness) {
             (Signedness::Signed, IntBitness::Xsize) => "isize",
             (Signedness::Signed, IntBitness::X8) => "i8",
diff --git a/crates/ra_hir/src/ty/traits.rs b/crates/ra_hir/src/ty/traits.rs
index 3c902451b..cff4de316 100644
--- a/crates/ra_hir/src/ty/traits.rs
+++ b/crates/ra_hir/src/ty/traits.rs
@@ -50,7 +50,7 @@ pub(crate) fn impls_for_trait_query(
         impls.extend(db.impls_for_trait(dep.krate, trait_).iter());
     }
     let crate_impl_blocks = db.impls_in_crate(krate);
-    impls.extend(crate_impl_blocks.lookup_impl_blocks_for_trait(&trait_));
+    impls.extend(crate_impl_blocks.lookup_impl_blocks_for_trait(trait_));
     impls.into_iter().collect::<Vec<_>>().into()
 }
 
-- 
cgit v1.2.3