From 0320ebdd101b01abe5f24e9efcef7c15005fd3a5 Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Mon, 9 Mar 2020 11:11:59 +0100 Subject: Use `Index` for CrateGraph --- crates/ra_hir_def/src/find_path.rs | 2 +- crates/ra_hir_def/src/lang_item.rs | 3 +-- crates/ra_hir_def/src/nameres.rs | 2 +- crates/ra_hir_def/src/nameres/collector.rs | 6 +++--- 4 files changed, 6 insertions(+), 7 deletions(-) (limited to 'crates/ra_hir_def') diff --git a/crates/ra_hir_def/src/find_path.rs b/crates/ra_hir_def/src/find_path.rs index 217e19b01..07ca74ec3 100644 --- a/crates/ra_hir_def/src/find_path.rs +++ b/crates/ra_hir_def/src/find_path.rs @@ -176,7 +176,7 @@ fn find_importable_locations( // directly (only through reexports in direct dependencies). for krate in Some(from.krate) .into_iter() - .chain(crate_graph.crate_data(&from.krate).dependencies.iter().map(|dep| dep.crate_id)) + .chain(crate_graph[from.krate].dependencies.iter().map(|dep| dep.crate_id)) { result.extend( importable_locations_in_crate(db, item, krate) diff --git a/crates/ra_hir_def/src/lang_item.rs b/crates/ra_hir_def/src/lang_item.rs index 79e8d8038..6de49730e 100644 --- a/crates/ra_hir_def/src/lang_item.rs +++ b/crates/ra_hir_def/src/lang_item.rs @@ -116,8 +116,7 @@ impl LangItems { if let Some(target) = start_crate_target { return Some(*target); } - db.crate_graph() - .crate_data(&start_crate) + db.crate_graph()[start_crate] .dependencies .iter() .find_map(|dep| db.lang_item(dep.crate_id, item.clone())) diff --git a/crates/ra_hir_def/src/nameres.rs b/crates/ra_hir_def/src/nameres.rs index 6af0f4a8e..066b43ef9 100644 --- a/crates/ra_hir_def/src/nameres.rs +++ b/crates/ra_hir_def/src/nameres.rs @@ -179,7 +179,7 @@ impl CrateDefMap { pub(crate) fn crate_def_map_query(db: &impl DefDatabase, krate: CrateId) -> Arc { let _p = profile("crate_def_map_query"); let def_map = { - let edition = db.crate_graph().crate_data(&krate).edition; + let edition = db.crate_graph()[krate].edition; let mut modules: Arena = Arena::default(); let root = modules.alloc(ModuleData::default()); CrateDefMap { diff --git a/crates/ra_hir_def/src/nameres/collector.rs b/crates/ra_hir_def/src/nameres/collector.rs index e69f89b80..bfa3db47a 100644 --- a/crates/ra_hir_def/src/nameres/collector.rs +++ b/crates/ra_hir_def/src/nameres/collector.rs @@ -34,7 +34,7 @@ pub(super) fn collect_defs(db: &impl DefDatabase, mut def_map: CrateDefMap) -> C let crate_graph = db.crate_graph(); // populate external prelude - for dep in &crate_graph.crate_data(&def_map.krate).dependencies { + for dep in &crate_graph[def_map.krate].dependencies { let dep_def_map = db.crate_def_map(dep.crate_id); log::debug!("crate dep {:?} -> {:?}", dep.name, dep.crate_id); def_map.extern_prelude.insert( @@ -128,7 +128,7 @@ where DB: DefDatabase, { fn collect(&mut self) { - let file_id = self.db.crate_graph().crate_data(&self.def_map.krate).root_file_id; + let file_id = self.db.crate_graph()[self.def_map.krate].root_file_id; let raw_items = self.db.raw_items(file_id.into()); let module_id = self.def_map.root; self.def_map.modules[module_id].origin = ModuleOrigin::CrateRoot { definition: file_id }; @@ -954,7 +954,7 @@ mod tests { let krate = db.test_crate(); let def_map = { - let edition = db.crate_graph().crate_data(&krate).edition; + let edition = db.crate_graph()[krate].edition; let mut modules: Arena = Arena::default(); let root = modules.alloc(ModuleData::default()); CrateDefMap { -- cgit v1.2.3