From 17f4d27f1285a76961b2e3957dc192de8e4f179f Mon Sep 17 00:00:00 2001 From: Jeremy Kolb Date: Sun, 19 Jul 2020 14:26:24 -0400 Subject: Minor perf tweaks per clippy --- crates/ra_ide/src/completion/completion_context.rs | 4 ++-- crates/ra_ide/src/diagnostics.rs | 2 +- crates/ra_ide/src/inlay_hints.rs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'crates/ra_ide/src') diff --git a/crates/ra_ide/src/completion/completion_context.rs b/crates/ra_ide/src/completion/completion_context.rs index 9e82d6854..c84d43d77 100644 --- a/crates/ra_ide/src/completion/completion_context.rs +++ b/crates/ra_ide/src/completion/completion_context.rs @@ -215,7 +215,7 @@ impl<'a> CompletionContext<'a> { fn fill_keyword_patterns(&mut self, file_with_fake_ident: &SyntaxNode, offset: TextSize) { let fake_ident_token = file_with_fake_ident.token_at_offset(offset).right_biased().unwrap(); - let syntax_element = NodeOrToken::Token(fake_ident_token.clone()); + let syntax_element = NodeOrToken::Token(fake_ident_token); self.block_expr_parent = has_block_expr_parent(syntax_element.clone()); self.unsafe_is_prev = unsafe_is_prev(syntax_element.clone()); self.if_is_prev = if_is_prev(syntax_element.clone()); @@ -228,7 +228,7 @@ impl<'a> CompletionContext<'a> { self.trait_as_prev_sibling = has_trait_as_prev_sibling(syntax_element.clone()); self.is_match_arm = is_match_arm(syntax_element.clone()); self.has_item_list_or_source_file_parent = - has_item_list_or_source_file_parent(syntax_element.clone()); + has_item_list_or_source_file_parent(syntax_element); } fn fill( diff --git a/crates/ra_ide/src/diagnostics.rs b/crates/ra_ide/src/diagnostics.rs index fe75f4b2c..e029af0dc 100644 --- a/crates/ra_ide/src/diagnostics.rs +++ b/crates/ra_ide/src/diagnostics.rs @@ -183,7 +183,7 @@ fn missing_struct_field_fix( } new_field = format!("\n{}{}", indent, new_field); - let needs_comma = !last_field_syntax.to_string().ends_with(","); + let needs_comma = !last_field_syntax.to_string().ends_with(','); if needs_comma { new_field = format!(",{}", new_field); } diff --git a/crates/ra_ide/src/inlay_hints.rs b/crates/ra_ide/src/inlay_hints.rs index 43a5e29b5..09883ab4d 100644 --- a/crates/ra_ide/src/inlay_hints.rs +++ b/crates/ra_ide/src/inlay_hints.rs @@ -171,7 +171,7 @@ fn get_param_name_hints( .map(|(param_name, arg)| InlayHint { range: arg.syntax().text_range(), kind: InlayKind::ParameterHint, - label: param_name.to_string().into(), + label: param_name.into(), }); acc.extend(hints); -- cgit v1.2.3