From 48bc0ca745a0ebdd61b7db3935582bf5ec95042b Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Sun, 5 Apr 2020 14:46:07 +0200 Subject: Make control token modifier less ambiguous In textmate, keyword.control is used for all kinds of things; in fact, the default scope mapping for keyword is keyword.control! So let's add a less ambiguous controlFlow modifier See Microsoft/vscode#94367 --- crates/ra_ide/src/syntax_highlighting.rs | 2 +- crates/ra_ide/src/syntax_highlighting/tags.rs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'crates/ra_ide') diff --git a/crates/ra_ide/src/syntax_highlighting.rs b/crates/ra_ide/src/syntax_highlighting.rs index 7fc94d3cd..d833a816b 100644 --- a/crates/ra_ide/src/syntax_highlighting.rs +++ b/crates/ra_ide/src/syntax_highlighting.rs @@ -232,7 +232,7 @@ fn highlight_element( | T![loop] | T![match] | T![return] - | T![while] => h | HighlightModifier::Control, + | T![while] => h | HighlightModifier::ControlFlow, T![unsafe] => h | HighlightModifier::Unsafe, _ => h, } diff --git a/crates/ra_ide/src/syntax_highlighting/tags.rs b/crates/ra_ide/src/syntax_highlighting/tags.rs index 8835a5de2..e8b138e1a 100644 --- a/crates/ra_ide/src/syntax_highlighting/tags.rs +++ b/crates/ra_ide/src/syntax_highlighting/tags.rs @@ -44,7 +44,7 @@ pub enum HighlightTag { #[repr(u8)] pub enum HighlightModifier { /// Used with keywords like `if` and `break`. - Control = 0, + ControlFlow = 0, /// `foo` in `fn foo(x: i32)` is a definition, `foo` in `foo(90 + 2)` is /// not. Definition, @@ -91,7 +91,7 @@ impl fmt::Display for HighlightTag { impl HighlightModifier { const ALL: &'static [HighlightModifier] = &[ - HighlightModifier::Control, + HighlightModifier::ControlFlow, HighlightModifier::Definition, HighlightModifier::Mutable, HighlightModifier::Unsafe, @@ -99,7 +99,7 @@ impl HighlightModifier { fn as_str(self) -> &'static str { match self { - HighlightModifier::Control => "control", + HighlightModifier::ControlFlow => "control", HighlightModifier::Definition => "declaration", HighlightModifier::Mutable => "mutable", HighlightModifier::Unsafe => "unsafe", -- cgit v1.2.3