From 9c45a9e58632966984a79e18aa5221efb65e0ead Mon Sep 17 00:00:00 2001 From: Shotaro Yamada Date: Wed, 25 Sep 2019 10:32:01 +0900 Subject: Remove redundant clone() --- crates/ra_ide_api/src/completion/completion_context.rs | 2 +- crates/ra_ide_api/src/completion/presentation.rs | 2 +- crates/ra_ide_api/src/diagnostics.rs | 2 +- crates/ra_ide_api/src/display/navigation_target.rs | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) (limited to 'crates/ra_ide_api/src') diff --git a/crates/ra_ide_api/src/completion/completion_context.rs b/crates/ra_ide_api/src/completion/completion_context.rs index 59bd3689b..57542152f 100644 --- a/crates/ra_ide_api/src/completion/completion_context.rs +++ b/crates/ra_ide_api/src/completion/completion_context.rs @@ -94,7 +94,7 @@ impl<'a> CompletionContext<'a> { // actual completion. let file = { let edit = AtomTextEdit::insert(offset, "intellijRulezz".to_string()); - original_parse.reparse(&edit).tree().to_owned() + original_parse.reparse(&edit).tree() }; // First, let's try to complete a reference to some declaration. diff --git a/crates/ra_ide_api/src/completion/presentation.rs b/crates/ra_ide_api/src/completion/presentation.rs index ad414412b..b8aa433c1 100644 --- a/crates/ra_ide_api/src/completion/presentation.rs +++ b/crates/ra_ide_api/src/completion/presentation.rs @@ -76,7 +76,7 @@ impl Completions { None, ), ScopeDef::MacroDef(mac) => { - self.add_macro(ctx, Some(local_name.clone()), *mac); + self.add_macro(ctx, Some(local_name), *mac); return; } ScopeDef::Unknown => { diff --git a/crates/ra_ide_api/src/diagnostics.rs b/crates/ra_ide_api/src/diagnostics.rs index 1ae152e5b..93e1e7c2d 100644 --- a/crates/ra_ide_api/src/diagnostics.rs +++ b/crates/ra_ide_api/src/diagnostics.rs @@ -86,7 +86,7 @@ pub(crate) fn diagnostics(db: &RootDatabase, file_id: FileId) -> Vec fix: Some(fix), }) }); - let source_file = db.parse(file_id).tree().to_owned(); + let source_file = db.parse(file_id).tree(); let src = hir::Source { file_id: file_id.into(), ast: hir::ModuleSource::SourceFile(source_file) }; if let Some(m) = hir::Module::from_definition(db, src) { diff --git a/crates/ra_ide_api/src/display/navigation_target.rs b/crates/ra_ide_api/src/display/navigation_target.rs index 11f73ccfd..d3e774bd0 100644 --- a/crates/ra_ide_api/src/display/navigation_target.rs +++ b/crates/ra_ide_api/src/display/navigation_target.rs @@ -304,7 +304,7 @@ impl NavigationTarget { pub(crate) fn docs_from_symbol(db: &RootDatabase, symbol: &FileSymbol) -> Option { let parse = db.parse(symbol.file_id); - let node = symbol.ptr.to_node(parse.tree().syntax()).to_owned(); + let node = symbol.ptr.to_node(parse.tree().syntax()); visitor() .visit(|it: ast::FnDef| it.doc_comment_text()) @@ -326,7 +326,7 @@ pub(crate) fn docs_from_symbol(db: &RootDatabase, symbol: &FileSymbol) -> Option /// e.g. `struct Name`, `enum Name`, `fn Name` pub(crate) fn description_from_symbol(db: &RootDatabase, symbol: &FileSymbol) -> Option { let parse = db.parse(symbol.file_id); - let node = symbol.ptr.to_node(parse.tree().syntax()).to_owned(); + let node = symbol.ptr.to_node(parse.tree().syntax()); visitor() .visit(|node: ast::FnDef| node.short_label()) -- cgit v1.2.3