From 5f31d495bdc8639a826f60c6f42d12bb89be9f1a Mon Sep 17 00:00:00 2001 From: Bernardo Date: Sat, 12 Jan 2019 20:32:24 +0100 Subject: reference `notify` issue --- crates/ra_vfs/src/lib.rs | 2 +- crates/ra_vfs/src/watcher.rs | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'crates/ra_vfs') diff --git a/crates/ra_vfs/src/lib.rs b/crates/ra_vfs/src/lib.rs index 2930f6b80..3eeec8b1c 100644 --- a/crates/ra_vfs/src/lib.rs +++ b/crates/ra_vfs/src/lib.rs @@ -225,7 +225,7 @@ impl Vfs { } } watcher::WatcherChange::Rescan => { - // TODO send Task::AddRoot? + // TODO we should reload all files } }, io::TaskResult::LoadChange(None) => {} diff --git a/crates/ra_vfs/src/watcher.rs b/crates/ra_vfs/src/watcher.rs index a5401869c..190a9f924 100644 --- a/crates/ra_vfs/src/watcher.rs +++ b/crates/ra_vfs/src/watcher.rs @@ -86,7 +86,8 @@ impl Watcher { pub fn shutdown(mut self) -> thread::Result<()> { self.bomb.defuse(); drop(self.watcher); - // TODO this doesn't terminate for some reason + // TODO this doesn't terminate because of a buf in `notify` + // uncomment when https://github.com/passcod/notify/pull/170 is released // let res = self.thread.join(); // match &res { // Ok(()) => log::info!("... Watcher terminated with ok"), -- cgit v1.2.3