From c9b4ac5be4daaabc062ab1ee663eba8594750003 Mon Sep 17 00:00:00 2001 From: Maan2003 Date: Sun, 13 Jun 2021 09:24:16 +0530 Subject: clippy::redudant_borrow --- crates/syntax/src/ast/edit.rs | 2 +- crates/syntax/src/ast/token_ext.rs | 2 +- crates/syntax/src/parsing.rs | 4 ++-- crates/syntax/src/parsing/lexer.rs | 2 +- crates/syntax/src/parsing/reparsing.rs | 6 +++--- crates/syntax/src/tests.rs | 4 ++-- 6 files changed, 10 insertions(+), 10 deletions(-) (limited to 'crates/syntax/src') diff --git a/crates/syntax/src/ast/edit.rs b/crates/syntax/src/ast/edit.rs index 19107ee38..8698687d8 100644 --- a/crates/syntax/src/ast/edit.rs +++ b/crates/syntax/src/ast/edit.rs @@ -30,7 +30,7 @@ impl ast::UseTree { let suffix = if self.path().as_ref() == Some(prefix) && self.use_tree_list().is_none() { make::path_unqualified(make::path_segment_self()) } else { - match split_path_prefix(&prefix) { + match split_path_prefix(prefix) { Some(it) => it, None => return self.clone(), } diff --git a/crates/syntax/src/ast/token_ext.rs b/crates/syntax/src/ast/token_ext.rs index 4b1e1ccee..ad52d9f54 100644 --- a/crates/syntax/src/ast/token_ext.rs +++ b/crates/syntax/src/ast/token_ext.rs @@ -242,7 +242,7 @@ impl ast::ByteString { (Ok(c), true) if char_range.len() == 1 && Some(c) == text_iter.next() => (), (Ok(c), true) => { buf.reserve_exact(text.len()); - buf.extend_from_slice(&text[..char_range.start].as_bytes()); + buf.extend_from_slice(text[..char_range.start].as_bytes()); buf.push(c as u8); } (Err(_), _) => has_error = true, diff --git a/crates/syntax/src/parsing.rs b/crates/syntax/src/parsing.rs index 431ed0699..001921343 100644 --- a/crates/syntax/src/parsing.rs +++ b/crates/syntax/src/parsing.rs @@ -15,7 +15,7 @@ use crate::{syntax_node::GreenNode, AstNode, SyntaxError, SyntaxNode}; pub(crate) use crate::parsing::{lexer::*, reparsing::incremental_reparse}; pub(crate) fn parse_text(text: &str) -> (GreenNode, Vec) { - let (tokens, lexer_errors) = tokenize(&text); + let (tokens, lexer_errors) = tokenize(text); let mut token_source = TextTokenSource::new(text, &tokens); let mut tree_sink = TextTreeSink::new(text, &tokens); @@ -33,7 +33,7 @@ pub(crate) fn parse_text_fragment( text: &str, fragment_kind: parser::FragmentKind, ) -> Result { - let (tokens, lexer_errors) = tokenize(&text); + let (tokens, lexer_errors) = tokenize(text); if !lexer_errors.is_empty() { return Err(()); } diff --git a/crates/syntax/src/parsing/lexer.rs b/crates/syntax/src/parsing/lexer.rs index 7c8d0a4c4..ae4844e48 100644 --- a/crates/syntax/src/parsing/lexer.rs +++ b/crates/syntax/src/parsing/lexer.rs @@ -144,7 +144,7 @@ fn rustc_token_kind_to_syntax_kind( } rustc_lexer::TokenKind::RawIdent => IDENT, - rustc_lexer::TokenKind::Literal { kind, .. } => return match_literal_kind(&kind), + rustc_lexer::TokenKind::Literal { kind, .. } => return match_literal_kind(kind), rustc_lexer::TokenKind::Lifetime { starts_with_number: false } => LIFETIME_IDENT, rustc_lexer::TokenKind::Lifetime { starts_with_number: true } => { diff --git a/crates/syntax/src/parsing/reparsing.rs b/crates/syntax/src/parsing/reparsing.rs index 304f47b3d..186cc9e74 100644 --- a/crates/syntax/src/parsing/reparsing.rs +++ b/crates/syntax/src/parsing/reparsing.rs @@ -26,11 +26,11 @@ pub(crate) fn incremental_reparse( edit: &Indel, errors: Vec, ) -> Option<(GreenNode, Vec, TextRange)> { - if let Some((green, new_errors, old_range)) = reparse_token(node, &edit) { + if let Some((green, new_errors, old_range)) = reparse_token(node, edit) { return Some((green, merge_errors(errors, new_errors, old_range, edit), old_range)); } - if let Some((green, new_errors, old_range)) = reparse_block(node, &edit) { + if let Some((green, new_errors, old_range)) = reparse_block(node, edit) { return Some((green, merge_errors(errors, new_errors, old_range, edit), old_range)); } None @@ -52,7 +52,7 @@ fn reparse_token( } } - let mut new_text = get_text_after_edit(prev_token.clone().into(), &edit); + let mut new_text = get_text_after_edit(prev_token.clone().into(), edit); let (new_token_kind, new_err) = lex_single_syntax_kind(&new_text)?; if new_token_kind != prev_token_kind diff --git a/crates/syntax/src/tests.rs b/crates/syntax/src/tests.rs index 9f2426171..4961ca08d 100644 --- a/crates/syntax/src/tests.rs +++ b/crates/syntax/src/tests.rs @@ -69,13 +69,13 @@ fn parser_tests() { dir_tests(&test_data_dir(), &["parser/inline/ok", "parser/ok"], "rast", |text, path| { let parse = SourceFile::parse(text); let errors = parse.errors(); - assert_errors_are_absent(&errors, path); + assert_errors_are_absent(errors, path); parse.debug_dump() }); dir_tests(&test_data_dir(), &["parser/err", "parser/inline/err"], "rast", |text, path| { let parse = SourceFile::parse(text); let errors = parse.errors(); - assert_errors_are_present(&errors, path); + assert_errors_are_present(errors, path); parse.debug_dump() }); } -- cgit v1.2.3 From b857a5dcf094728b4beefd652ea31d2828eb0e10 Mon Sep 17 00:00:00 2001 From: Maan2003 Date: Sun, 13 Jun 2021 09:37:28 +0530 Subject: clippy::manual_str_repeat --- crates/syntax/src/ast/edit.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'crates/syntax/src') diff --git a/crates/syntax/src/ast/edit.rs b/crates/syntax/src/ast/edit.rs index 8698687d8..2663c0759 100644 --- a/crates/syntax/src/ast/edit.rs +++ b/crates/syntax/src/ast/edit.rs @@ -95,7 +95,7 @@ impl fmt::Display for IndentLevel { let indent = if len <= spaces.len() { &spaces[..len] } else { - buf = iter::repeat(' ').take(len).collect::(); + buf = " ".repeat(len); &buf }; fmt::Display::fmt(indent, f) -- cgit v1.2.3