From e6e4417bbbcc7e135d1b372e4e278cd3efa2d4b8 Mon Sep 17 00:00:00 2001 From: Lukas Wirth Date: Fri, 23 Apr 2021 18:36:43 +0200 Subject: Remove SyntaxRewriter::from_fn --- crates/syntax/src/algo.rs | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) (limited to 'crates/syntax/src') diff --git a/crates/syntax/src/algo.rs b/crates/syntax/src/algo.rs index a153a9e1c..c9229c4e0 100644 --- a/crates/syntax/src/algo.rs +++ b/crates/syntax/src/algo.rs @@ -342,10 +342,10 @@ enum InsertPos { #[derive(Default)] pub struct SyntaxRewriter<'a> { - f: Option Option + 'a>>, //FIXME: add debug_assertions that all elements are in fact from the same file. replacements: FxHashMap, insertions: IndexMap>, + _pd: std::marker::PhantomData<&'a ()>, } impl fmt::Debug for SyntaxRewriter<'_> { @@ -357,14 +357,7 @@ impl fmt::Debug for SyntaxRewriter<'_> { } } -impl<'a> SyntaxRewriter<'a> { - pub fn from_fn(f: impl Fn(&SyntaxElement) -> Option + 'a) -> SyntaxRewriter<'a> { - SyntaxRewriter { - f: Some(Box::new(f)), - replacements: FxHashMap::default(), - insertions: IndexMap::default(), - } - } +impl SyntaxRewriter<'_> { pub fn delete>(&mut self, what: &T) { let what = what.clone().into(); let replacement = Replacement::Delete; @@ -470,7 +463,7 @@ impl<'a> SyntaxRewriter<'a> { pub fn rewrite(&self, node: &SyntaxNode) -> SyntaxNode { let _p = profile::span("rewrite"); - if self.f.is_none() && self.replacements.is_empty() && self.insertions.is_empty() { + if self.replacements.is_empty() && self.insertions.is_empty() { return node.clone(); } let green = self.rewrite_children(node); @@ -495,7 +488,6 @@ impl<'a> SyntaxRewriter<'a> { } } - assert!(self.f.is_none()); self.replacements .keys() .filter_map(element_to_node_or_parent) @@ -510,10 +502,6 @@ impl<'a> SyntaxRewriter<'a> { } fn replacement(&self, element: &SyntaxElement) -> Option { - if let Some(f) = &self.f { - assert!(self.replacements.is_empty()); - return f(element).map(Replacement::Single); - } self.replacements.get(element).cloned() } @@ -574,7 +562,6 @@ fn element_to_green(element: SyntaxElement) -> NodeOrToken { fn add_assign(&mut self, rhs: SyntaxRewriter) { - assert!(rhs.f.is_none()); self.replacements.extend(rhs.replacements); for (pos, insertions) in rhs.insertions.into_iter() { match self.insertions.entry(pos) { -- cgit v1.2.3