From 8af9a18660f9b2f34da902f43c1eef856af1cfca Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Tue, 15 Jan 2019 18:33:26 +0300 Subject: remove Cancelable from Crate API --- crates/ra_hir/src/code_model_api.rs | 6 +++--- crates/ra_hir/src/code_model_impl/krate.rs | 8 ++++---- crates/ra_hir/src/nameres.rs | 4 ++-- crates/ra_hir/src/ty/method_resolution.rs | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) (limited to 'crates') diff --git a/crates/ra_hir/src/code_model_api.rs b/crates/ra_hir/src/code_model_api.rs index 81638e384..db270b871 100644 --- a/crates/ra_hir/src/code_model_api.rs +++ b/crates/ra_hir/src/code_model_api.rs @@ -33,10 +33,10 @@ impl Crate { pub fn crate_id(&self) -> CrateId { self.crate_id } - pub fn dependencies(&self, db: &impl HirDatabase) -> Cancelable> { - Ok(self.dependencies_impl(db)) + pub fn dependencies(&self, db: &impl HirDatabase) -> Vec { + self.dependencies_impl(db) } - pub fn root_module(&self, db: &impl HirDatabase) -> Cancelable> { + pub fn root_module(&self, db: &impl HirDatabase) -> Option { self.root_module_impl(db) } } diff --git a/crates/ra_hir/src/code_model_impl/krate.rs b/crates/ra_hir/src/code_model_impl/krate.rs index 712c6c86a..8c6e34873 100644 --- a/crates/ra_hir/src/code_model_impl/krate.rs +++ b/crates/ra_hir/src/code_model_impl/krate.rs @@ -1,4 +1,4 @@ -use ra_db::{CrateId, Cancelable}; +use ra_db::CrateId; use crate::{ HirFileId, Crate, CrateDependency, AsName, DefLoc, DefKind, Module, SourceItemId, @@ -20,7 +20,7 @@ impl Crate { }) .collect() } - pub(crate) fn root_module_impl(&self, db: &impl HirDatabase) -> Cancelable> { + pub(crate) fn root_module_impl(&self, db: &impl HirDatabase) -> Option { let crate_graph = db.crate_graph(); let file_id = crate_graph.crate_root(self.crate_id); let source_root_id = db.file_source_root(file_id); @@ -31,7 +31,7 @@ impl Crate { file_id, item_id: None, }; - let module_id = ctry!(module_tree.find_module_by_source(source)); + let module_id = module_tree.find_module_by_source(source)?; let def_loc = DefLoc { kind: DefKind::Module, @@ -42,6 +42,6 @@ impl Crate { let def_id = def_loc.id(db); let module = Module::new(def_id); - Ok(Some(module)) + Some(module) } } diff --git a/crates/ra_hir/src/nameres.rs b/crates/ra_hir/src/nameres.rs index edb3b1e64..e51cbe786 100644 --- a/crates/ra_hir/src/nameres.rs +++ b/crates/ra_hir/src/nameres.rs @@ -353,8 +353,8 @@ where if let Some(crate_id) = crate_graph.crate_id_for_crate_root(file_id.as_original_file()) { let krate = Crate::new(crate_id); - for dep in krate.dependencies(self.db)? { - if let Some(module) = dep.krate.root_module(self.db)? { + for dep in krate.dependencies(self.db) { + if let Some(module) = dep.krate.root_module(self.db) { let def_id = module.def_id; self.add_module_item( &mut module_items, diff --git a/crates/ra_hir/src/ty/method_resolution.rs b/crates/ra_hir/src/ty/method_resolution.rs index f0da2ee2b..c7fbcfd06 100644 --- a/crates/ra_hir/src/ty/method_resolution.rs +++ b/crates/ra_hir/src/ty/method_resolution.rs @@ -93,7 +93,7 @@ impl CrateImplBlocks { source_root_id, impls: FxHashMap::default(), }; - if let Some(module) = krate.root_module(db)? { + if let Some(module) = krate.root_module(db) { crate_impl_blocks.collect_recursive(db, module)?; } Ok(Arc::new(crate_impl_blocks)) -- cgit v1.2.3