From ef0da3bbeccdaab3813a1f6a17c566ca9087615f Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Thu, 21 May 2020 16:11:37 +0200 Subject: Cleanup --- crates/ra_ide/src/join_lines.rs | 24 ++++++++++++++++++------ crates/ra_ide/src/lib.rs | 3 --- crates/ra_ide/src/test_utils.rs | 25 ------------------------- 3 files changed, 18 insertions(+), 34 deletions(-) delete mode 100644 crates/ra_ide/src/test_utils.rs (limited to 'crates') diff --git a/crates/ra_ide/src/join_lines.rs b/crates/ra_ide/src/join_lines.rs index d3af780c4..af1ade8a1 100644 --- a/crates/ra_ide/src/join_lines.rs +++ b/crates/ra_ide/src/join_lines.rs @@ -166,16 +166,28 @@ fn is_trailing_comma(left: SyntaxKind, right: SyntaxKind) -> bool { #[cfg(test)] mod tests { - use crate::test_utils::{assert_eq_text, check_action, extract_range}; + use ra_syntax::SourceFile; + use test_utils::{add_cursor, assert_eq_text, extract_offset, extract_range}; use super::*; fn check_join_lines(before: &str, after: &str) { - check_action(before, after, |file, offset| { - let range = TextRange::empty(offset); - let res = join_lines(file, range); - Some(res) - }) + let (before_cursor_pos, before) = extract_offset(before); + let file = SourceFile::parse(&before).ok().unwrap(); + + let range = TextRange::empty(before_cursor_pos); + let result = join_lines(&file, range); + + let actual = { + let mut actual = before.to_string(); + result.apply(&mut actual); + actual + }; + let actual_cursor_pos = result + .apply_to_offset(before_cursor_pos) + .expect("cursor position is affected by the edit"); + let actual = add_cursor(&actual, actual_cursor_pos); + assert_eq_text!(after, &actual); } #[test] diff --git a/crates/ra_ide/src/lib.rs b/crates/ra_ide/src/lib.rs index 1d7bacbf6..d0aeb3ba7 100644 --- a/crates/ra_ide/src/lib.rs +++ b/crates/ra_ide/src/lib.rs @@ -42,9 +42,6 @@ mod inlay_hints; mod expand_macro; mod ssr; -#[cfg(test)] -mod test_utils; - use std::sync::Arc; use ra_cfg::CfgOptions; diff --git a/crates/ra_ide/src/test_utils.rs b/crates/ra_ide/src/test_utils.rs deleted file mode 100644 index b335582a3..000000000 --- a/crates/ra_ide/src/test_utils.rs +++ /dev/null @@ -1,25 +0,0 @@ -//! FIXME: write short doc here - -use ra_syntax::{SourceFile, TextSize}; -use ra_text_edit::TextEdit; - -pub(crate) use test_utils::*; - -pub(crate) fn check_action Option>( - before: &str, - after: &str, - f: F, -) { - let (before_cursor_pos, before) = extract_offset(before); - let file = SourceFile::parse(&before).ok().unwrap(); - let result = f(&file, before_cursor_pos).expect("code action is not applicable"); - let actual = { - let mut actual = before.to_string(); - result.apply(&mut actual); - actual - }; - let actual_cursor_pos = - result.apply_to_offset(before_cursor_pos).expect("cursor position is affected by the edit"); - let actual = add_cursor(&actual, actual_cursor_pos); - assert_eq_text!(after, &actual); -} -- cgit v1.2.3