From e81a47b8ebce9bcf680b15c6e0c1e879200f75df Mon Sep 17 00:00:00 2001 From: Michael Bolin Date: Wed, 10 Jul 2019 22:49:29 -0700 Subject: Remove executeCommandProvider: apply_code_action. This appears to have been introduced ages ago in https://github.com/rust-analyzer/rust-analyzer/commit/be742a587704f27f4e503c50f549aa9ec1527fcc but has since been removed. As it stands, it is problematic if multiple instances of the rust-analyzer LSP are launched during the same VS Code session because VS Code complains about multiple LSP servers trying to register the same command. Most LSP servers workaround this by parameterizing the command by the process id. For example, this is where `rls` does this: https://github.com/rust-lang/rls/blob/ff0b9057c8f62bc4f8113d741e96c9587ef1a817/rls/src/server/mod.rs#L413-L421 Though `apply_code_action` does not seems to be used, so it seems better to delete it than to parameterize it. --- docs/dev/lsp-features.md | 2 -- 1 file changed, 2 deletions(-) (limited to 'docs/dev/lsp-features.md') diff --git a/docs/dev/lsp-features.md b/docs/dev/lsp-features.md index 28bae59bb..d3e79b8be 100644 --- a/docs/dev/lsp-features.md +++ b/docs/dev/lsp-features.md @@ -16,8 +16,6 @@ This list documents LSP features, supported by rust-analyzer. - [ ] [workspace/configuration](https://microsoft.github.io/language-server-protocol/specification#workspace_configuration) - [x] [workspace/didChangeWatchedFiles](https://microsoft.github.io/language-server-protocol/specification#workspace_didChangeWatchedFiles) - [x] [workspace/symbol](https://microsoft.github.io/language-server-protocol/specification#workspace_symbol) -- [x] [workspace/executeCommand](https://microsoft.github.io/language-server-protocol/specification#workspace_executeCommand) - - `apply_code_action` - [ ] [workspace/applyEdit](https://microsoft.github.io/language-server-protocol/specification#workspace_applyEdit) ## Text Synchronization -- cgit v1.2.3