From 742055e29f1b25063e291d021640430e58698b73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=96mer=20Sinan=20A=C4=9Facan?= Date: Thu, 30 Apr 2020 23:27:06 +0300 Subject: Update Roslyn link in syntax.md Eric Lippert has a new blog that he keeps updating, update the link to that --- docs/dev/syntax.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'docs/dev') diff --git a/docs/dev/syntax.md b/docs/dev/syntax.md index 4dd1de659..33973ffec 100644 --- a/docs/dev/syntax.md +++ b/docs/dev/syntax.md @@ -35,7 +35,7 @@ The syntax tree consists of three layers: * AST Of these, only GreenNodes store the actual data, the other two layers are (non-trivial) views into green tree. -Red-green terminology comes from Roslyn ([link](https://docs.microsoft.com/en-ie/archive/blogs/ericlippert/persistence-facades-and-roslyns-red-green-trees)) and gives the name to the `rowan` library. Green and syntax nodes are defined in rowan, ast is defined in rust-analyzer. +Red-green terminology comes from Roslyn ([link](https://ericlippert.com/2012/06/08/red-green-trees/)) and gives the name to the `rowan` library. Green and syntax nodes are defined in rowan, ast is defined in rust-analyzer. Syntax trees are a semi-transient data structure. In general, frontend does not keep syntax trees for all files in memory. -- cgit v1.2.3 From eafb2107dd176c60730f2c11a1c66d878064703c Mon Sep 17 00:00:00 2001 From: KENTARO OKUDA Date: Fri, 1 May 2020 09:43:08 -0400 Subject: Fix Typos --- docs/dev/architecture.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'docs/dev') diff --git a/docs/dev/architecture.md b/docs/dev/architecture.md index 3a337c574..cee916c09 100644 --- a/docs/dev/architecture.md +++ b/docs/dev/architecture.md @@ -46,7 +46,7 @@ can be quickly updated for small modifications. Some of the components of this repository are generated through automatic processes. `cargo xtask codegen` runs all generation tasks. Generated code is -commited to the git repository. +committed to the git repository. In particular, `cargo xtask codegen` generates: @@ -114,7 +114,7 @@ is responsible for guessing a HIR for a particular source position. Underneath, HIR works on top of salsa, using a `HirDatabase` trait. `ra_hir_xxx` crates have a strong ECS flavor, in that they work with raw ids and -directly query the databse. +directly query the database. The top-level `ra_hir` façade crate wraps ids into a more OO-flavored API. -- cgit v1.2.3 From f5d20b6525bc87773dc3757cf58cb51cdd6a21a0 Mon Sep 17 00:00:00 2001 From: KENTARO OKUDA Date: Fri, 1 May 2020 14:00:06 -0400 Subject: Fix Typos on guide.md --- docs/dev/guide.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'docs/dev') diff --git a/docs/dev/guide.md b/docs/dev/guide.md index abbe4c154..c3252f1f6 100644 --- a/docs/dev/guide.md +++ b/docs/dev/guide.md @@ -26,7 +26,7 @@ properties hold: ## IDE API -To see the bigger picture of how the IDE features works, let's take a look at the [`AnalysisHost`] and +To see the bigger picture of how the IDE features work, let's take a look at the [`AnalysisHost`] and [`Analysis`] pair of types. `AnalysisHost` has three methods: * `default()` for creating an empty analysis instance @@ -131,7 +131,7 @@ mapping between `SourceRoot` IDs (which are assigned by the client) and actual analyzer. Note that `mod`, `#[path]` and `include!()` can only reference files from the -same source root. It is of course is possible to explicitly add extra files to +same source root. It is of course possible to explicitly add extra files to the source root, even `/dev/random`. ## Language Server Protocol @@ -192,7 +192,7 @@ task will be canceled as soon as the main loop calls `apply_change` on the [`schedule`]: https://github.com/rust-analyzer/rust-analyzer/blob/guide-2019-01/crates/ra_lsp_server/src/main_loop.rs#L426-L455 [The task]: https://github.com/rust-analyzer/rust-analyzer/blob/guide-2019-01/crates/ra_lsp_server/src/main_loop/handlers.rs#L205-L223 -This concludes the overview of the analyzer's programing *interface*. Next, lets +This concludes the overview of the analyzer's programing *interface*. Next, let's dig into the implementation! ## Salsa @@ -480,7 +480,7 @@ throughout the analyzer: ## Source Map pattern Due to an obscure edge case in completion, IDE needs to know the syntax node of -an use statement which imported the given completion candidate. We can't just +a use statement which imported the given completion candidate. We can't just store the syntax node as a part of name resolution: this will break incrementality, due to the fact that syntax changes after every file modification. -- cgit v1.2.3