From ad24310d4146df8174048d6537192f51b35a391b Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Tue, 13 Apr 2021 14:13:50 +0300 Subject: internal: document review requesting etiquette * don't feel obliged to quickly review every PR assigned to you * so that other folks can notify you about interesting PRs without thinking to much about creating additional work for you --- docs/dev/README.md | 3 +++ 1 file changed, 3 insertions(+) (limited to 'docs/dev') diff --git a/docs/dev/README.md b/docs/dev/README.md index d0e6d29d8..360cedf88 100644 --- a/docs/dev/README.md +++ b/docs/dev/README.md @@ -242,6 +242,9 @@ There are three sets of people with extra permissions: They also have direct commit access, but all changes should via bors queue. It's ok to self-approve if you think you know what you are doing! bors should automatically sync the permissions. + Feel free to assign any PR to a reviewer with the relevant expertise to bring the work to their attention. + Don't feel pressured to review assigned PRs though. + If you don't feel like reviewing for whatever reason, someone else will pick the review up! * [**triage**](https://github.com/orgs/rust-analyzer/teams/triage) team in the organization. This team can label and close issues. -- cgit v1.2.3