From ad24310d4146df8174048d6537192f51b35a391b Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Tue, 13 Apr 2021 14:13:50 +0300 Subject: internal: document review requesting etiquette * don't feel obliged to quickly review every PR assigned to you * so that other folks can notify you about interesting PRs without thinking to much about creating additional work for you --- docs/dev/README.md | 3 +++ 1 file changed, 3 insertions(+) (limited to 'docs/dev') diff --git a/docs/dev/README.md b/docs/dev/README.md index d0e6d29d8..360cedf88 100644 --- a/docs/dev/README.md +++ b/docs/dev/README.md @@ -242,6 +242,9 @@ There are three sets of people with extra permissions: They also have direct commit access, but all changes should via bors queue. It's ok to self-approve if you think you know what you are doing! bors should automatically sync the permissions. + Feel free to assign any PR to a reviewer with the relevant expertise to bring the work to their attention. + Don't feel pressured to review assigned PRs though. + If you don't feel like reviewing for whatever reason, someone else will pick the review up! * [**triage**](https://github.com/orgs/rust-analyzer/teams/triage) team in the organization. This team can label and close issues. -- cgit v1.2.3 From 453b9cf6f0e4ad49592f1994cc328b26dc88bd2e Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Tue, 13 Apr 2021 14:53:02 +0300 Subject: Update docs/dev/README.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Laurențiu Nicola --- docs/dev/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'docs/dev') diff --git a/docs/dev/README.md b/docs/dev/README.md index 360cedf88..7e4488a41 100644 --- a/docs/dev/README.md +++ b/docs/dev/README.md @@ -242,7 +242,7 @@ There are three sets of people with extra permissions: They also have direct commit access, but all changes should via bors queue. It's ok to self-approve if you think you know what you are doing! bors should automatically sync the permissions. - Feel free to assign any PR to a reviewer with the relevant expertise to bring the work to their attention. + Feel free to request a review or assign any PR to a reviewer with the relevant expertise to bring the work to their attention. Don't feel pressured to review assigned PRs though. If you don't feel like reviewing for whatever reason, someone else will pick the review up! * [**triage**](https://github.com/orgs/rust-analyzer/teams/triage) team in the organization. -- cgit v1.2.3