From 9dae94a78dd5b660dd97f884b91067c55b4a418e Mon Sep 17 00:00:00 2001 From: Veetaha Date: Sat, 7 Mar 2020 23:59:33 +0200 Subject: vscode: contribute "alwaysDownloadServer" option to config --- editors/code/package.json | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'editors/code/package.json') diff --git a/editors/code/package.json b/editors/code/package.json index 225739328..7bcd45e15 100644 --- a/editors/code/package.json +++ b/editors/code/package.json @@ -219,6 +219,11 @@ } } }, + "rust-analyzer.alwaysDownloadServer": { + "type": "boolean", + "default": false, + "description": "Whether to ask before downloading the language server binary" + }, "rust-analyzer.serverPath": { "type": [ "null", -- cgit v1.2.3 From 6bd1ff16e5e517c89a154b9b26847d20656e1184 Mon Sep 17 00:00:00 2001 From: Veetaha Date: Sun, 8 Mar 2020 18:58:02 +0200 Subject: vscode: rename alwaysDownloadServer -> askBeforeDownload The new name seems much simpler and it doesn't limit this config value only to downloading the server binary. Thus we wouldn't need to create another config properties to handle other downloads whatsoever. Anyway, I believe (heuristically) that most of the users would want to set "askBeforeDownload": false once and never bother clicking on the notification again (because otherwise there is no big point in installing rust-analyzer if it cannot install the server) --- editors/code/package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'editors/code/package.json') diff --git a/editors/code/package.json b/editors/code/package.json index 7bcd45e15..430a61c64 100644 --- a/editors/code/package.json +++ b/editors/code/package.json @@ -219,10 +219,10 @@ } } }, - "rust-analyzer.alwaysDownloadServer": { + "rust-analyzer.askBeforeDownload": { "type": "boolean", - "default": false, - "description": "Whether to ask before downloading the language server binary" + "default": true, + "description": "Whether to ask for permission before downloading any files from the Internet" }, "rust-analyzer.serverPath": { "type": [ -- cgit v1.2.3 From ce65cc949f9e183c7c166212b4f3d7d4abd102b0 Mon Sep 17 00:00:00 2001 From: Veetaha Date: Mon, 9 Mar 2020 10:59:36 +0200 Subject: vscode: groupd updates-related config under `updates` section as per @matklad --- editors/code/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'editors/code/package.json') diff --git a/editors/code/package.json b/editors/code/package.json index 430a61c64..6827c822b 100644 --- a/editors/code/package.json +++ b/editors/code/package.json @@ -219,7 +219,7 @@ } } }, - "rust-analyzer.askBeforeDownload": { + "rust-analyzer.updates.askBeforeDownload": { "type": "boolean", "default": true, "description": "Whether to ask for permission before downloading any files from the Internet" -- cgit v1.2.3