From 65cecff316e9217eb0f58df189a3f05de5d8d51c Mon Sep 17 00:00:00 2001 From: Veetaha Date: Sat, 7 Mar 2020 14:39:42 +0200 Subject: vscode: post refactor HintsUpdater (simplify create() -> constructor call) --- editors/code/src/inlay_hints.ts | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) (limited to 'editors/code') diff --git a/editors/code/src/inlay_hints.ts b/editors/code/src/inlay_hints.ts index fd7c49c89..e1a82e03e 100644 --- a/editors/code/src/inlay_hints.ts +++ b/editors/code/src/inlay_hints.ts @@ -13,7 +13,7 @@ export function activateInlayHints(ctx: Ctx) { if (!ctx.config.displayInlayHints) { return this.dispose(); } - if (!this.updater) this.updater = HintsUpdater.create(ctx); + if (!this.updater) this.updater = new HintsUpdater(ctx); }, dispose() { this.updater?.dispose(); @@ -67,25 +67,21 @@ class HintsUpdater implements Disposable { private sourceFiles = new Map(); // map Uri -> RustSourceFile private readonly disposables: Disposable[] = []; - private constructor(private readonly ctx: Ctx) { } - - static create(ctx: Ctx) { - const self = new HintsUpdater(ctx); - + constructor(private readonly ctx: Ctx) { vscode.window.onDidChangeVisibleTextEditors( - self.onDidChangeVisibleTextEditors, - self, - self.disposables + this.onDidChangeVisibleTextEditors, + this, + this.disposables ); vscode.workspace.onDidChangeTextDocument( - self.onDidChangeTextDocument, - self, - self.disposables + this.onDidChangeTextDocument, + this, + this.disposables ); // Set up initial cache shape - ctx.visibleRustEditors.forEach(editor => self.sourceFiles.set( + ctx.visibleRustEditors.forEach(editor => this.sourceFiles.set( editor.document.uri.toString(), { document: editor.document, @@ -94,9 +90,7 @@ class HintsUpdater implements Disposable { } )); - self.syncCacheAndRenderHints(); - - return self; + this.syncCacheAndRenderHints(); } dispose() { -- cgit v1.2.3