From de2324d9e6aa378d28799aaaa3336e6efb7a06b7 Mon Sep 17 00:00:00 2001 From: Veetaha Date: Sat, 29 Aug 2020 02:05:42 +0300 Subject: Remove fixme from inlay_hints.ts I have reevaluated the fixme and it doesn't seem necessary to pass an array of files to the inlay hints request. This will (a) make the request more compilcated (b), make us wait for inlay hints for `all` active editors resolve at once before rendering and (c) doesn't seem required because 99% of the time there is a single active editor in the IDE --- editors/code/src/inlay_hints.ts | 1 - 1 file changed, 1 deletion(-) (limited to 'editors') diff --git a/editors/code/src/inlay_hints.ts b/editors/code/src/inlay_hints.ts index 7b481fc72..30ade9b98 100644 --- a/editors/code/src/inlay_hints.ts +++ b/editors/code/src/inlay_hints.ts @@ -111,7 +111,6 @@ class HintsUpdater implements Disposable { } syncCacheAndRenderHints() { - // FIXME: make inlayHints request pass an array of files? this.sourceFiles.forEach((file, uri) => this.fetchHints(file).then(hints => { if (!hints) return; -- cgit v1.2.3