From 0ae26c344aa7477a18c2019cfa0062a9a745d70d Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Fri, 9 Feb 2018 22:44:50 +0300 Subject: Drop ErrorBuilder nonsense --- src/parser/grammar/attributes.rs | 8 ++++---- src/parser/grammar/expressions.rs | 2 +- src/parser/grammar/items/mod.rs | 8 ++++---- src/parser/grammar/items/structs.rs | 4 ++-- src/parser/grammar/items/use_item.rs | 2 +- src/parser/grammar/mod.rs | 6 +++--- src/parser/grammar/paths.rs | 4 +++- 7 files changed, 18 insertions(+), 16 deletions(-) (limited to 'src/parser/grammar') diff --git a/src/parser/grammar/attributes.rs b/src/parser/grammar/attributes.rs index 8bf04afce..92dfb99ef 100644 --- a/src/parser/grammar/attributes.rs +++ b/src/parser/grammar/attributes.rs @@ -37,7 +37,7 @@ fn meta_item(p: &mut Parser) { EQ => { p.bump(); if !expressions::literal(p) { - p.error().message("expected literal").emit(); + p.error("expected literal"); } } L_PAREN => meta_item_arg_list(p), @@ -45,7 +45,7 @@ fn meta_item(p: &mut Parser) { } meta_item.complete(p, META_ITEM); } else { - p.error().message("expected attribute value").emit() + p.error("expected attribute value"); } } @@ -60,12 +60,12 @@ fn meta_item_arg_list(p: &mut Parser) { let message = "expected attribute"; if items::ITEM_FIRST.contains(c) { - p.error().message(message).emit(); + p.error(message); return; } let err = p.start(); - p.error().message(message).emit(); + p.error(message); p.bump(); err.complete(p, ERROR); continue; diff --git a/src/parser/grammar/expressions.rs b/src/parser/grammar/expressions.rs index 8caaf3553..3704cb16f 100644 --- a/src/parser/grammar/expressions.rs +++ b/src/parser/grammar/expressions.rs @@ -15,6 +15,6 @@ pub(super) fn literal(p: &mut Parser) -> bool { pub(super) fn expr(p: &mut Parser) { if !literal(p) { - p.error().message("expected expression").emit(); + p.error("expected expression"); } } diff --git a/src/parser/grammar/items/mod.rs b/src/parser/grammar/items/mod.rs index 37f2ab132..b73628ec0 100644 --- a/src/parser/grammar/items/mod.rs +++ b/src/parser/grammar/items/mod.rs @@ -51,7 +51,7 @@ fn item(p: &mut Parser) { // extern struct Foo; _ => { item.abandon(p); - p.error().message("expected `fn` or `{`").emit(); + p.error("expected `fn` or `{`"); return; } } @@ -121,7 +121,7 @@ fn item(p: &mut Parser) { abi(p); if !p.at(FN_KW) { item.abandon(p); - p.error().message("expected function").emit(); + p.error("expected function"); return; } fn_item(p); @@ -144,7 +144,7 @@ fn item(p: &mut Parser) { if t == L_CURLY { error_block(p, message); } else { - p.error().message(message).emit(); + p.error(message); } return; } @@ -234,7 +234,7 @@ fn fn_item(p: &mut Parser) { if p.at(L_PAREN) { fn_value_parameters(p); } else { - p.error().message("expected function arguments").emit(); + p.error("expected function arguments"); } if p.at(L_CURLY) { diff --git a/src/parser/grammar/items/structs.rs b/src/parser/grammar/items/structs.rs index 69d95c698..640b940e4 100644 --- a/src/parser/grammar/items/structs.rs +++ b/src/parser/grammar/items/structs.rs @@ -19,7 +19,7 @@ pub(super) fn struct_item(p: &mut Parser) { L_CURLY => named_fields(p), _ => { //TODO: special case `(` error message - p.error().message("expected `;` or `{`").emit(); + p.error("expected `;` or `{`"); return; } } @@ -34,7 +34,7 @@ pub(super) fn struct_item(p: &mut Parser) { p.expect(SEMI); } _ => { - p.error().message("expected `;`, `{`, or `(`").emit(); + p.error("expected `;`, `{`, or `(`"); return; } } diff --git a/src/parser/grammar/items/use_item.rs b/src/parser/grammar/items/use_item.rs index 38e7b3f8a..a3f7f0da8 100644 --- a/src/parser/grammar/items/use_item.rs +++ b/src/parser/grammar/items/use_item.rs @@ -37,7 +37,7 @@ fn use_tree(p: &mut Parser) { L_CURLY => nested_trees(p), _ => { // is this unreachable? - p.error().message("expected `{` or `*`").emit(); + p.error("expected `{` or `*`"); } } } diff --git a/src/parser/grammar/mod.rs b/src/parser/grammar/mod.rs index afce308d0..b949583ff 100644 --- a/src/parser/grammar/mod.rs +++ b/src/parser/grammar/mod.rs @@ -53,7 +53,7 @@ fn alias(p: &mut Parser) -> bool { fn error_block(p: &mut Parser, message: &str) { assert!(p.at(L_CURLY)); let err = p.start(); - p.error().message(message).emit(); + p.error(message); p.bump(); let mut level: u32 = 1; while level > 0 && !p.at(EOF) { @@ -74,7 +74,7 @@ impl<'p> Parser<'p> { fn err_and_bump(&mut self, message: &str) { let err = self.start(); - self.error().message(message).emit(); + self.error(message); self.bump(); err.complete(self, ERROR); } @@ -84,7 +84,7 @@ impl<'p> Parser<'p> { self.bump(); true } else { - self.error().message(format!("expected {:?}", kind)).emit(); + self.error(format!("expected {:?}", kind)); false } } diff --git a/src/parser/grammar/paths.rs b/src/parser/grammar/paths.rs index 6efac2610..1aa30f28b 100644 --- a/src/parser/grammar/paths.rs +++ b/src/parser/grammar/paths.rs @@ -43,7 +43,9 @@ fn path_segment(p: &mut Parser, first: bool) { } match p.current() { IDENT | SELF_KW | SUPER_KW => p.bump(), - _ => p.error().message("expected identifier").emit(), + _ => { + p.error("expected identifier"); + }, }; segment.complete(p, PATH_SEGMENT); } -- cgit v1.2.3