From c9b4ac5be4daaabc062ab1ee663eba8594750003 Mon Sep 17 00:00:00 2001 From: Maan2003 Date: Sun, 13 Jun 2021 09:24:16 +0530 Subject: clippy::redudant_borrow --- xtask/src/codegen/gen_lint_completions.rs | 2 +- xtask/src/codegen/gen_syntax.rs | 6 +++--- xtask/src/metrics.rs | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'xtask') diff --git a/xtask/src/codegen/gen_lint_completions.rs b/xtask/src/codegen/gen_lint_completions.rs index 3b54b2489..4aebb02bd 100644 --- a/xtask/src/codegen/gen_lint_completions.rs +++ b/xtask/src/codegen/gen_lint_completions.rs @@ -28,7 +28,7 @@ pub(crate) fn generate_lint_completions() -> Result<()> { contents.push('\n'); cmd!("curl https://rust-lang.github.io/rust-clippy/master/lints.json --output ./target/clippy_lints.json").run()?; - generate_descriptor_clippy(&mut contents, &Path::new("./target/clippy_lints.json"))?; + generate_descriptor_clippy(&mut contents, Path::new("./target/clippy_lints.json"))?; let contents = reformat(&contents)?; let destination = project_root().join("crates/ide_db/src/helpers/generated_lints.rs"); diff --git a/xtask/src/codegen/gen_syntax.rs b/xtask/src/codegen/gen_syntax.rs index b0b9e30db..5435da76e 100644 --- a/xtask/src/codegen/gen_syntax.rs +++ b/xtask/src/codegen/gen_syntax.rs @@ -258,7 +258,7 @@ fn generate_nodes(kinds: KindsSrc<'_>, grammar: &AstSrc) -> Result { for chunk in ast.split("# [pretty_doc_comment_placeholder_workaround] ") { res.push_str(chunk); if let Some(doc) = docs.next() { - write_doc_comment(&doc, &mut res); + write_doc_comment(doc, &mut res); } } @@ -294,14 +294,14 @@ fn generate_syntax_kinds(grammar: KindsSrc<'_>) -> Result { let full_keywords_values = &grammar.keywords; let full_keywords = - full_keywords_values.iter().map(|kw| format_ident!("{}_KW", to_upper_snake_case(&kw))); + full_keywords_values.iter().map(|kw| format_ident!("{}_KW", to_upper_snake_case(kw))); let all_keywords_values = grammar.keywords.iter().chain(grammar.contextual_keywords.iter()).collect::>(); let all_keywords_idents = all_keywords_values.iter().map(|kw| format_ident!("{}", kw)); let all_keywords = all_keywords_values .iter() - .map(|name| format_ident!("{}_KW", to_upper_snake_case(&name))) + .map(|name| format_ident!("{}_KW", to_upper_snake_case(name))) .collect::>(); let literals = diff --git a/xtask/src/metrics.rs b/xtask/src/metrics.rs index 34679062f..7b190d425 100644 --- a/xtask/src/metrics.rs +++ b/xtask/src/metrics.rs @@ -71,7 +71,7 @@ impl Metrics { Ok(()) } fn measure_analysis_stats_self(&mut self) -> Result<()> { - self.measure_analysis_stats_path("self", &".") + self.measure_analysis_stats_path("self", ".") } fn measure_analysis_stats(&mut self, bench: &str) -> Result<()> { self.measure_analysis_stats_path( -- cgit v1.2.3 From 6cc6dee9e96d55dbbd8593523551a9981a691147 Mon Sep 17 00:00:00 2001 From: Maan2003 Date: Sun, 13 Jun 2021 09:25:55 +0530 Subject: clippy::useless_conversion --- xtask/src/codegen/gen_lint_completions.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'xtask') diff --git a/xtask/src/codegen/gen_lint_completions.rs b/xtask/src/codegen/gen_lint_completions.rs index 4aebb02bd..54fcaa0e6 100644 --- a/xtask/src/codegen/gen_lint_completions.rs +++ b/xtask/src/codegen/gen_lint_completions.rs @@ -140,8 +140,7 @@ fn generate_descriptor_clippy(buf: &mut String, path: &Path) -> Result<()> { .expect("should be prefixed by what it does") .strip_suffix(suffix_to_strip) .map(unescape) - .expect("should be suffixed by comma") - .into(); + .expect("should be suffixed by comma"); } } clippy_lints.sort_by(|lint, lint2| lint.id.cmp(&lint2.id)); -- cgit v1.2.3