//! `ra_assists` crate provides a bunch of code assists, also known as code //! actions (in LSP) or intentions (in IntelliJ). //! //! An assist is a micro-refactoring, which is automatically activated in //! certain context. For example, if the cursor is over `,`, a "swap `,`" assist //! becomes available. mod assist_ctx; mod marks; #[cfg(test)] mod doc_tests; pub mod ast_transform; use either::Either; use hir::ModuleDef; use ra_db::FileRange; use ra_ide_db::{imports_locator::ImportsLocatorIde, RootDatabase}; use ra_syntax::{TextRange, TextUnit}; use ra_text_edit::TextEdit; pub(crate) use crate::assist_ctx::{Assist, AssistCtx}; pub use crate::assists::add_import::auto_import_text_edit; /// Unique identifier of the assist, should not be shown to the user /// directly. #[derive(Debug, Clone, Copy, PartialEq, Eq)] pub struct AssistId(pub &'static str); #[derive(Debug, Clone)] pub struct AssistLabel { /// Short description of the assist, as shown in the UI. pub label: String, pub id: AssistId, } #[derive(Debug, Clone)] pub struct AssistAction { pub label: Option, pub edit: TextEdit, pub cursor_position: Option, pub target: Option, } #[derive(Debug, Clone)] pub struct ResolvedAssist { pub label: AssistLabel, pub action_data: Either>, } impl ResolvedAssist { pub fn get_first_action(&self) -> AssistAction { match &self.action_data { Either::Left(action) => action.clone(), Either::Right(actions) => actions[0].clone(), } } } /// Return all the assists applicable at the given position. /// /// Assists are returned in the "unresolved" state, that is only labels are /// returned, without actual edits. pub fn applicable_assists(db: &RootDatabase, range: FileRange) -> Vec { AssistCtx::with_ctx(db, range, false, |ctx| { assists::all() .iter() .filter_map(|f| f(ctx.clone())) .map(|a| match a { Assist::Unresolved { label } => label, Assist::Resolved { .. } => unreachable!(), }) .collect() }) } /// A functionality for locating imports for the given name. /// /// Currently has to be a trait with the real implementation provided by the ra_ide_api crate, /// due to the search functionality located there. /// Later, this trait should be removed completely and the search functionality moved to a separate crate, /// accessible from the ra_assists crate. pub trait ImportsLocator { /// Finds all imports for the given name and the module that contains this name. fn find_imports(&mut self, name_to_import: &str) -> Vec; } impl ImportsLocator for ImportsLocatorIde<'_> { fn find_imports(&mut self, name_to_import: &str) -> Vec { self.find_imports(name_to_import) } } /// Return all the assists applicable at the given position /// and additional assists that need the imports locator functionality to work. /// /// Assists are returned in the "resolved" state, that is with edit fully /// computed. pub fn assists_with_imports_locator(db: &RootDatabase, range: FileRange) -> Vec { let mut imports_locator = ImportsLocatorIde::new(db); AssistCtx::with_ctx(db, range, true, |ctx| { let mut assists = assists::all() .iter() .map(|f| f(ctx.clone())) .chain( assists::all_with_imports_locator() .iter() .map(|f| f(ctx.clone(), &mut imports_locator)), ) .filter_map(std::convert::identity) .map(|a| match a { Assist::Resolved { assist } => assist, Assist::Unresolved { .. } => unreachable!(), }) .collect(); sort_assists(&mut assists); assists }) } /// Return all the assists applicable at the given position. /// /// Assists are returned in the "resolved" state, that is with edit fully /// computed. pub fn assists(db: &RootDatabase, range: FileRange) -> Vec { AssistCtx::with_ctx(db, range, true, |ctx| { let mut a = assists::all() .iter() .filter_map(|f| f(ctx.clone())) .map(|a| match a { Assist::Resolved { assist } => assist, Assist::Unresolved { .. } => unreachable!(), }) .collect(); sort_assists(&mut a); a }) } fn sort_assists(assists: &mut Vec) { use std::cmp::Ordering; assists.sort_by(|a, b| match (a.get_first_action().target, b.get_first_action().target) { (Some(a), Some(b)) => a.len().cmp(&b.len()), (Some(_), None) => Ordering::Less, (None, Some(_)) => Ordering::Greater, (None, None) => Ordering::Equal, }); } mod assists { use crate::{Assist, AssistCtx, ImportsLocator}; mod add_derive; mod add_explicit_type; mod add_impl; mod add_custom_impl; mod add_new; mod apply_demorgan; mod auto_import; mod invert_if; mod flip_comma; mod flip_binexpr; mod flip_trait_bound; mod change_visibility; mod fill_match_arms; mod merge_match_arms; mod introduce_variable; mod inline_local_variable; mod raw_string; mod replace_if_let_with_match; mod split_import; mod remove_dbg; pub(crate) mod add_import; mod add_missing_impl_members; mod move_guard; mod move_bounds; mod early_return; pub(crate) fn all() -> &'static [fn(AssistCtx) -> Option] { &[ add_derive::add_derive, add_explicit_type::add_explicit_type, add_impl::add_impl, add_custom_impl::add_custom_impl, add_new::add_new, apply_demorgan::apply_demorgan, invert_if::invert_if, change_visibility::change_visibility, fill_match_arms::fill_match_arms, merge_match_arms::merge_match_arms, flip_comma::flip_comma, flip_binexpr::flip_binexpr, flip_trait_bound::flip_trait_bound, introduce_variable::introduce_variable, replace_if_let_with_match::replace_if_let_with_match, split_import::split_import, remove_dbg::remove_dbg, add_import::add_import, add_missing_impl_members::add_missing_impl_members, add_missing_impl_members::add_missing_default_members, inline_local_variable::inline_local_variable, move_guard::move_guard_to_arm_body, move_guard::move_arm_cond_to_match_guard, move_bounds::move_bounds_to_where_clause, raw_string::add_hash, raw_string::make_raw_string, raw_string::make_usual_string, raw_string::remove_hash, early_return::convert_to_guarded_return, ] } pub(crate) fn all_with_imports_locator<'a, F: ImportsLocator>( ) -> &'a [fn(AssistCtx, &mut F) -> Option] { &[auto_import::auto_import] } } #[cfg(test)] mod helpers { use hir::db::DefDatabase; use ra_db::{fixture::WithFixture, FileId, FileRange}; use ra_syntax::TextRange; use test_utils::{add_cursor, assert_eq_text, extract_offset, extract_range}; use crate::{Assist, AssistCtx, ImportsLocator}; use ra_ide_db::RootDatabase; use std::sync::Arc; // FIXME remove the `ModuleDefId` reexport from `ra_hir` when this gets removed. pub(crate) struct TestImportsLocator { db: Arc, test_file_id: FileId, } impl TestImportsLocator { pub(crate) fn new(db: Arc, test_file_id: FileId) -> Self { TestImportsLocator { db, test_file_id } } } impl ImportsLocator for TestImportsLocator { fn find_imports(&mut self, name_to_import: &str) -> Vec { let crate_def_map = self.db.crate_def_map(self.db.test_crate()); let mut findings = Vec::new(); let mut module_ids_to_process = crate_def_map.modules_for_file(self.test_file_id).collect::>(); while !module_ids_to_process.is_empty() { let mut more_ids_to_process = Vec::new(); for local_module_id in module_ids_to_process.drain(..) { for (name, namespace_data) in crate_def_map[local_module_id].scope.entries_without_primitives() { let found_a_match = &name.to_string() == name_to_import; vec![namespace_data.types, namespace_data.values] .into_iter() .filter_map(std::convert::identity) .for_each(|(module_def_id, _)| { if found_a_match { findings.push(module_def_id.into()); } if let hir::ModuleDefId::ModuleId(module_id) = module_def_id { more_ids_to_process.push(module_id.local_id); } }); } } module_ids_to_process = more_ids_to_process; } findings } } pub(crate) fn check_assist(assist: fn(AssistCtx) -> Option, before: &str, after: &str) { let (before_cursor_pos, before) = extract_offset(before); let (db, file_id) = RootDatabase::with_single_file(&before); let frange = FileRange { file_id, range: TextRange::offset_len(before_cursor_pos, 0.into()) }; let assist = AssistCtx::with_ctx(&db, frange, true, assist).expect("code action is not applicable"); let action = match assist { Assist::Unresolved { .. } => unreachable!(), Assist::Resolved { assist } => assist.get_first_action(), }; let actual = action.edit.apply(&before); let actual_cursor_pos = match action.cursor_position { None => action .edit .apply_to_offset(before_cursor_pos) .expect("cursor position is affected by the edit"), Some(off) => off, }; let actual = add_cursor(&actual, actual_cursor_pos); assert_eq_text!(after, &actual); } pub(crate) fn check_assist_with_imports_locator( assist: fn(AssistCtx, &mut F) -> Option, imports_locator_provider: fn(db: Arc, file_id: FileId) -> F, before: &str, after: &str, ) { let (before_cursor_pos, before) = extract_offset(before); let (db, file_id) = RootDatabase::with_single_file(&before); let db = Arc::new(db); let mut imports_locator = imports_locator_provider(Arc::clone(&db), file_id); let frange = FileRange { file_id, range: TextRange::offset_len(before_cursor_pos, 0.into()) }; let assist = AssistCtx::with_ctx(db.as_ref(), frange, true, |ctx| assist(ctx, &mut imports_locator)) .expect("code action is not applicable"); let action = match assist { Assist::Unresolved { .. } => unreachable!(), Assist::Resolved { assist } => assist.get_first_action(), }; let actual = action.edit.apply(&before); let actual_cursor_pos = match action.cursor_position { None => action .edit .apply_to_offset(before_cursor_pos) .expect("cursor position is affected by the edit"), Some(off) => off, }; let actual = add_cursor(&actual, actual_cursor_pos); assert_eq_text!(after, &actual); } pub(crate) fn check_assist_range( assist: fn(AssistCtx) -> Option, before: &str, after: &str, ) { let (range, before) = extract_range(before); let (db, file_id) = RootDatabase::with_single_file(&before); let frange = FileRange { file_id, range }; let assist = AssistCtx::with_ctx(&db, frange, true, assist).expect("code action is not applicable"); let action = match assist { Assist::Unresolved { .. } => unreachable!(), Assist::Resolved { assist } => assist.get_first_action(), }; let mut actual = action.edit.apply(&before); if let Some(pos) = action.cursor_position { actual = add_cursor(&actual, pos); } assert_eq_text!(after, &actual); } pub(crate) fn check_assist_target( assist: fn(AssistCtx) -> Option, before: &str, target: &str, ) { let (before_cursor_pos, before) = extract_offset(before); let (db, file_id) = RootDatabase::with_single_file(&before); let frange = FileRange { file_id, range: TextRange::offset_len(before_cursor_pos, 0.into()) }; let assist = AssistCtx::with_ctx(&db, frange, true, assist).expect("code action is not applicable"); let action = match assist { Assist::Unresolved { .. } => unreachable!(), Assist::Resolved { assist } => assist.get_first_action(), }; let range = action.target.expect("expected target on action"); assert_eq_text!(&before[range.start().to_usize()..range.end().to_usize()], target); } pub(crate) fn check_assist_range_target( assist: fn(AssistCtx) -> Option, before: &str, target: &str, ) { let (range, before) = extract_range(before); let (db, file_id) = RootDatabase::with_single_file(&before); let frange = FileRange { file_id, range }; let assist = AssistCtx::with_ctx(&db, frange, true, assist).expect("code action is not applicable"); let action = match assist { Assist::Unresolved { .. } => unreachable!(), Assist::Resolved { assist } => assist.get_first_action(), }; let range = action.target.expect("expected target on action"); assert_eq_text!(&before[range.start().to_usize()..range.end().to_usize()], target); } pub(crate) fn check_assist_not_applicable( assist: fn(AssistCtx) -> Option, before: &str, ) { let (before_cursor_pos, before) = extract_offset(before); let (db, file_id) = RootDatabase::with_single_file(&before); let frange = FileRange { file_id, range: TextRange::offset_len(before_cursor_pos, 0.into()) }; let assist = AssistCtx::with_ctx(&db, frange, true, assist); assert!(assist.is_none()); } pub(crate) fn check_assist_with_imports_locator_not_applicable( assist: fn(AssistCtx, &mut F) -> Option, imports_locator_provider: fn(db: Arc, file_id: FileId) -> F, before: &str, ) { let (before_cursor_pos, before) = extract_offset(before); let (db, file_id) = RootDatabase::with_single_file(&before); let db = Arc::new(db); let mut imports_locator = imports_locator_provider(Arc::clone(&db), file_id); let frange = FileRange { file_id, range: TextRange::offset_len(before_cursor_pos, 0.into()) }; let assist = AssistCtx::with_ctx(db.as_ref(), frange, true, |ctx| assist(ctx, &mut imports_locator)); assert!(assist.is_none()); } pub(crate) fn check_assist_range_not_applicable( assist: fn(AssistCtx) -> Option, before: &str, ) { let (range, before) = extract_range(before); let (db, file_id) = RootDatabase::with_single_file(&before); let frange = FileRange { file_id, range }; let assist = AssistCtx::with_ctx(&db, frange, true, assist); assert!(assist.is_none()); } } #[cfg(test)] mod tests { use ra_db::{fixture::WithFixture, FileRange}; use ra_syntax::TextRange; use test_utils::{extract_offset, extract_range}; use ra_ide_db::RootDatabase; #[test] fn assist_order_field_struct() { let before = "struct Foo { <|>bar: u32 }"; let (before_cursor_pos, before) = extract_offset(before); let (db, file_id) = RootDatabase::with_single_file(&before); let frange = FileRange { file_id, range: TextRange::offset_len(before_cursor_pos, 0.into()) }; let assists = super::assists(&db, frange); let mut assists = assists.iter(); assert_eq!( assists.next().expect("expected assist").label.label, "Change visibility to pub(crate)" ); assert_eq!(assists.next().expect("expected assist").label.label, "Add `#[derive]`"); } #[test] fn assist_order_if_expr() { let before = " pub fn test_some_range(a: int) -> bool { if let 2..6 = <|>5<|> { true } else { false } }"; let (range, before) = extract_range(before); let (db, file_id) = RootDatabase::with_single_file(&before); let frange = FileRange { file_id, range }; let assists = super::assists(&db, frange); let mut assists = assists.iter(); assert_eq!(assists.next().expect("expected assist").label.label, "Extract into variable"); assert_eq!(assists.next().expect("expected assist").label.label, "Replace with match"); } }