From fc6409142e68335addc65763a1733526130256b0 Mon Sep 17 00:00:00 2001
From: Akshay <nerdy@peppe.rs>
Date: Sun, 3 Oct 2021 16:57:34 +0530
Subject: new lint: collapsible_let_in

---
 lib/src/lints/collapsible_let_in.rs | 60 +++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 lib/src/lints/collapsible_let_in.rs

(limited to 'lib/src/lints/collapsible_let_in.rs')

diff --git a/lib/src/lints/collapsible_let_in.rs b/lib/src/lints/collapsible_let_in.rs
new file mode 100644
index 0000000..c2cdf9b
--- /dev/null
+++ b/lib/src/lints/collapsible_let_in.rs
@@ -0,0 +1,60 @@
+use crate::{make, Lint, Metadata, Report, Rule, Suggestion};
+
+use if_chain::if_chain;
+use macros::lint;
+use rowan::Direction;
+use rnix::{
+    types::{LetIn, TypedNode},
+    NodeOrToken, SyntaxElement, SyntaxKind, TextRange
+};
+
+#[lint(
+    name = "collapsible let in",
+    note = "These let-in expressions are collapsible",
+    code = 6,
+    match_with = SyntaxKind::NODE_LET_IN
+)]
+struct CollapsibleLetIn;
+
+impl Rule for CollapsibleLetIn {
+    fn validate(&self, node: &SyntaxElement) -> Option<Report> {
+        if_chain! {
+            if let NodeOrToken::Node(node) = node;
+            if let Some(let_in_expr) = LetIn::cast(node.clone());
+            if let Some(body) = let_in_expr.body();
+
+            if LetIn::cast(body.clone()).is_some();
+            then {
+                let first_annotation = node.text_range();
+                let first_message = "This let-in expression contains a nested let-in expression";
+
+                let second_annotation = body.text_range();
+                let second_message = "This let-in expression is nested";
+
+                let replacement_at = {
+                    let start = body
+                        .siblings_with_tokens(Direction::Prev)
+                        .find(|elem| elem.kind() == SyntaxKind::TOKEN_IN)?
+                        .text_range()
+                        .start();
+                    let end = body
+                        .descendants_with_tokens()
+                        .find(|elem| elem.kind() == SyntaxKind::TOKEN_LET)?
+                        .text_range()
+                        .end();
+                    TextRange::new(start, end)
+                };
+                let replacement = make::empty().node().clone();
+
+                Some(
+                    Self::report()
+                        .diagnostic(first_annotation, first_message)
+                        .suggest(second_annotation, second_message, Suggestion::new(replacement_at, replacement))
+                )
+            } else {
+                None
+            }
+        }
+    }
+}
+
-- 
cgit v1.2.3